Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump AWS SDK for EKS Pod Identity #5974

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Dec 13, 2024

What problem does this PR solve?

What is changed and how does it work?

bump AWS SDK to match https://github.com/aws/aws-sdk-go-v2/releases/tag/release-2023-12-06

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge December 13, 2024 08:03
@ti-chi-bot ti-chi-bot bot added the size/M label Dec 13, 2024
@csuzhangxc
Copy link
Member Author

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.92%. Comparing base (a16b2e8) to head (4302511).
Report is 14 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a16b2e8) and HEAD (4302511). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a16b2e8) HEAD (4302511)
unittest 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5974       +/-   ##
===========================================
- Coverage   57.19%   46.92%   -10.27%     
===========================================
  Files         259      220       -39     
  Lines       33233    31249     -1984     
===========================================
- Hits        19008    14665     -4343     
- Misses      12291    14835     +2544     
+ Partials     1934     1749      -185     
Flag Coverage Δ
e2e 46.92% <ø> (?)
unittest ?

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-serial

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-tikv-scale-simultaneously

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-tikv-scale-simultaneously

@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-basic

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc csuzhangxc merged commit 67cb56a into pingcap:master Dec 16, 2024
12 of 13 checks passed
@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.6

@csuzhangxc csuzhangxc deleted the bump-aws branch December 16, 2024 09:36
@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.6: #5979.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-operator that referenced this pull request Dec 16, 2024
@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5980.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc added a commit that referenced this pull request Dec 17, 2024
csuzhangxc added a commit that referenced this pull request Dec 17, 2024
Signed-off-by: ti-chi-bot <[email protected]>
Co-authored-by: Cody (Xuecheng) Zhang <[email protected]>
RidRisR pushed a commit to RidRisR/tidb-operator that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants