Fix background height and padding in non-iframe editor canvas #63222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This issue first appeared in WP6.6 and I expect it will affect many sites, so hopefully it will be backported to WP6.6. |
t-hamano
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: -2 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Not sure what I'm doing wrong, but even with jetpack installed or one of the core blocks manually set to v2, the editor is still iframed. Maybe I'll try hacking the code to force a non-iframed canvas, though this has me concerned that there's another bug. |
I think the theme also has to be a non-block theme? |
|
Sorry, I missed it, but this problem may not be reproducible with block themes. Because if the Gutenberg plugin is enabled and it is a block theme, the You should be able to reproduce the issue with Jetpack enabled in the following environments:
|
|
Thank you everyone for your reviews! |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jul 8, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: stokesman <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 196c4db |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
…ess#63222) Co-authored-by: t-hamano <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: stokesman <[email protected]>
|
Hey @t-hamano , it looks like this has introduced a problem with tablet/mobile mode when a metabox with a lot of content is present. |
11 tasks
2 tasks
|
@enricobattocchi Thanks for the report. Yes, I have confirmed that this PR does indeed cause issues in mobile/tablet views. I have summarized the cause in #63708. I would like to explore a more ideal solution. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ess#63222) Co-authored-by: t-hamano <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: stokesman <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63110
Related to #62940
What?
This PR fixes two issues with the background when the post editor is not an iframe but does not have a meta box:
There is not enough space at the bottom of the content
The background color disappears halfway through
Why?
In #62940, the post editor was styled as follows to fix the triple scroll issue:
This style works in the non-iframe editor where meta boxes (custom fields) are enabled. However, the post editor will not become an iframe if there is a v2 or lower block present, even if it does not have a meta box. In this case, the
.has-metaboxesclass does not exist, so the editor defaults toheight:100%, which seems to cause the issue mentioned above.How?
I used
.is-iframedinstead of.has-metaboxesclass to accurately determine if the editor is an iframe or not.Testing Instructions
Also, there have been some scrollbar fixes in this area in the past, so please make sure we have not run into regressions or unwanted scrollbars in the following cases:
wp.data.dispatch( 'core/notices' ).createInfoNotice( 'Notice' );)Note: However, there is one issue that this PR doesn't solve: when you open the Pattern Editor in a non-iframe editor, the background gets cut off.
I believe the root cause of this issue is based on the fact that when the post editor is not an iframe, the pattern editor is not an iframe either. I believe the pattern editor should be an iframe regardless of whether the post editor is an iframe or not, just like the tablet and mobile views. However, since this change is impactful, I thought it should be addressed in a follow-up.
Screenshots or screencast
54b0e79636057729f77648cc991f7361.mp4