Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cura 5.2.1 #208124

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Cura 5.2.1 #208124

wants to merge 7 commits into from

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Dec 28, 2022

Description of changes

Replacement of PR #175191. If this one gets merged, closes #175191.

In this approach I used the patches from Alpine Linux (see patches) section.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

TODO

  • cura builds
    • curaengine builds
      • libarcus builds
      • uranium builds
    • libsavitar builds (unclar if needed, Alpine does not use it)
  • Squash all my old WIP commits, make commit messages proper

nh2 added 7 commits December 28, 2022 12:42
@nh2
curaengine: Reformat library lists
5e40f38
@nh2
cura, curaengine, python3Packages.libarcus, python3Packages.libsavita…
9d5a500 
…r, python3Packages.uranium: 4.*.* -> 5.0.0

The `sed` expressions for the Python packages were replaced by upstream's new
ability to set the install path via a CMake `-D` variable.
@nh2
WIP: Make curaengine build. Lots of commented-out stuff, and small cu…
ce3168c 
…raengine source patch
@nh2
WIP: libarcus compiles at 5.2.0
468c6fe 
The setting of `-DPython_VERSION` is no longer necessary since
Ultimaker/libArcus@429b05e#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL55
@nh2
WIP: uranium builds at 5.2.0
248418f
@nh2
WIP: curaengine builds at 5.2.1
34ba8ec
@nh2
WIP: Trying to build cura 5.2.1. Does not work yet because there's no…
acfdd7d 
… `bin/`
@nh2 nh2 requested review from FRidh and jonringer as code owners December 28, 2022 16:18
This was referenced Dec 28, 2022
Draft
Open
@ofborg ofborg bot requested review from abbradar and gebner December 28, 2022 16:28
LunNova
LunNova reviewed Dec 28, 2022
View reviewed changes
pkgs/applications/misc/cura/default.nix
@@ -52,7 +67,11 @@ mkDerivation rec {

postFixup = ''
wrapPythonPrograms
wrapQtApp $out/bin/cura

# find $out/bin
Copy link
Member

@LunNova LunNova Dec 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover debug code?

Missed that this isn't ready for review.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've only done the Cura dependencies, not Cura itself.

@StefanBruens StefanBruens mentioned this pull request Jan 4, 2023
Closed
@eraserhd
Copy link
Contributor

eraserhd commented Jan 16, 2023 •
edited
Loading

EDIT: Nevermind: was an error in my dotfiles. curaengine does build for me: eraserhd/dotfiles@3bd90e2

@nh2 nh2 marked this pull request as draft January 16, 2023 12:55
@Majiir
Copy link
Contributor

Majiir commented Sep 17, 2023

What's the status of this? Is there anything in particular that someone can help with?

I tried the appimage workaround described in #186570 (comment) but the performance is very poor.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/packaging-curaengine-5-4-0/33719/2

@pbek
Copy link
Contributor

pbek commented Feb 11, 2024

Is this still a draft? Cura 5 would be really nice! 😉

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/packaging-curaengine-5-4-0/33719/5

@pbek
Copy link
Contributor

pbek commented Feb 22, 2024

I tested the PR with:

gh pr checkout 208124
nix-build -A cura

It errored for me with:

qtOwnPathsHook
glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
wrapping Qt applications in /nix/store/yl9gd12iwdw9qqkhyl285rh0am6yg9hj-cura-5.2.1/bin /nix/store/yl9gd12iwdw9qqkhyl285rh0am6yg9hj-cura-5.2.1/sbin /nix/store/yl9gd12iwdw9qqkhyl285rh0am6yg9hj-cura-5.2.1/libexec /nix/store/yl9gd12iwdw9qqkhyl285rh0am6yg9hj-cura-5.2.1/Applications
shrinking RPATHs of ELF executables and libraries in /nix/store/yl9gd12iwdw9qqkhyl285rh0am6yg9hj-cura-5.2.1
strip is /nix/store/wn31i3dzwahz6ccws8bs1nwyqrpgsvj7-gcc-wrapper-11.3.0/bin/strip
stripping (with command strip and flags -S) in  /nix/store/yl9gd12iwdw9qqkhyl285rh0am6yg9hj-cura-5.2.1/lib
patching script interpreter paths in /nix/store/yl9gd12iwdw9qqkhyl285rh0am6yg9hj-cura-5.2.1
checking for references to /build/ in /nix/store/yl9gd12iwdw9qqkhyl285rh0am6yg9hj-cura-5.2.1...

Builder called die: Cannot wrap '/nix/store/yl9gd12iwdw9qqkhyl285rh0am6yg9hj-cura-5.2.1/bin/cura_app.py' because it is not an executable file
Backtrace:
7 assertExecutable /nix/store/ck0nhyc1sadhb7v012va5xv2mhc7lc9c-hook/nix-support/setup-hook
213 wrapProgramShell /nix/store/ck0nhyc1sadhb7v012va5xv2mhc7lc9c-hook/nix-support/setup-hook
208 wrapProgram /nix/store/ck0nhyc1sadhb7v012va5xv2mhc7lc9c-hook/nix-support/setup-hook
49 wrapQtApp /nix/store/0fp3gss1l0hrfwacs5w6g3w6nawlhq65-hook/nix-support/setup-hook
92 _callImplicitHook /nix/store/cp65c8nk29qq5cl1wyy5qyw103cwmax7-stdenv-linux/setup
104 _eval /nix/store/cp65c8nk29qq5cl1wyy5qyw103cwmax7-stdenv-linux/setup
47 runHook /nix/store/cp65c8nk29qq5cl1wyy5qyw103cwmax7-stdenv-linux/setup
1268 fixupPhase /nix/store/cp65c8nk29qq5cl1wyy5qyw103cwmax7-stdenv-linux/setup
1398 genericBuild /nix/store/cp65c8nk29qq5cl1wyy5qyw103cwmax7-stdenv-linux/setup
2 main /nix/store/9krlzvny65gdc8s7kpb6lkx8cd02c25b-default-builder.sh

error: builder for '/nix/store/3g1j6yspjddccv94d6z6hn2v1i6jb7h5-cura-5.2.1.drv' failed with exit code 1;
       last 10 log lines:
       > 213 wrapProgramShell /nix/store/ck0nhyc1sadhb7v012va5xv2mhc7lc9c-hook/nix-support/setup-hook
       > 208 wrapProgram /nix/store/ck0nhyc1sadhb7v012va5xv2mhc7lc9c-hook/nix-support/setup-hook
       > 49 wrapQtApp /nix/store/0fp3gss1l0hrfwacs5w6g3w6nawlhq65-hook/nix-support/setup-hook
       > 92 _callImplicitHook /nix/store/cp65c8nk29qq5cl1wyy5qyw103cwmax7-stdenv-linux/setup
       > 104 _eval /nix/store/cp65c8nk29qq5cl1wyy5qyw103cwmax7-stdenv-linux/setup
       > 47 runHook /nix/store/cp65c8nk29qq5cl1wyy5qyw103cwmax7-stdenv-linux/setup
       > 1268 fixupPhase /nix/store/cp65c8nk29qq5cl1wyy5qyw103cwmax7-stdenv-linux/setup
       > 1398 genericBuild /nix/store/cp65c8nk29qq5cl1wyy5qyw103cwmax7-stdenv-linux/setup
       > 2 main /nix/store/9krlzvny65gdc8s7kpb6lkx8cd02c25b-default-builder.sh
       >
       For full logs, run 'nix log /nix/store/3g1j6yspjddccv94d6z6hn2v1i6jb7h5-cura-5.2.1.drv'.

@pbek pbek mentioned this pull request Feb 22, 2024
Closed
16 tasks
@etrigan63
Copy link

Just for the record, Cura 5.6.0 has been out since last November and 5.7 is in the works.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunNova LunNova LunNova left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@abbradar abbradar Awaiting requested review from abbradar

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nh2 @eraserhd @Majiir @nixos-discourse @pbek @etrigan63 @LunNova @wegank