-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cura: 4.12.1 -> 5.1.0 #189042
cura: 4.12.1 -> 5.1.0 #189042
Conversation
0e4bbd6
to
e7ab54a
Compare
The approach I took to get this to build is pretty hacky :/ I think this needs a cmake expert to clean it up. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/packaging-curaengine-5-4-0/33719/2 |
This badly needs someone who understands what conan and its cmake is trying to do to help clean it up or find a better approach. It's really janky right now :( |
Hm, there was one on the 5.2 draft pull request, #208124. 🤔 |
I appreciate the effort, im new to NixOS and just installed cura only to realize its still on 4.x while we already have 5.6 .-. |
Oh, closing this was fine. I gave up on trying to tidy this up properly. 😅 |
Description of changes
This works for single models, marketplace doesn't work, multiple models crashes.
The Qt/PyQt changes are from #186689 and can go away once it's merged.
Fixes #186570
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes