Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cura: 4.12.1 -> 5.1.0 #189042

Closed
wants to merge 5 commits into from
Closed

Conversation

LunNova
Copy link
Member

@LunNova LunNova commented Aug 31, 2022

Description of changes

This works for single models, marketplace doesn't work, multiple models crashes.

The Qt/PyQt changes are from #186689 and can go away once it's merged.

Fixes #186570

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 31, 2022
@LunNova LunNova force-pushed the lunnova/cura-upgrade-2 branch from 0e4bbd6 to e7ab54a Compare October 13, 2022 04:24
@LunNova
Copy link
Member Author

LunNova commented Oct 13, 2022

The approach I took to get this to build is pretty hacky :/

I think this needs a cmake expert to clean it up.

@LunNova LunNova removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 13, 2022
@ofborg ofborg bot requested review from abbradar and gebner October 13, 2022 04:35
@LunNova LunNova mentioned this pull request Oct 13, 2022
2 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/packaging-curaengine-5-4-0/33719/2

@pbek
Copy link
Contributor

pbek commented Feb 22, 2024

I tested the PR with:

gh pr checkout 189042
nix-build -A cura
./result/bin/cura

Looks quite good to me:

image

@LunNova
Copy link
Member Author

LunNova commented Feb 22, 2024

This badly needs someone who understands what conan and its cmake is trying to do to help clean it up or find a better approach. It's really janky right now :(

@pbek
Copy link
Contributor

pbek commented Feb 22, 2024

Hm, there was one on the 5.2 draft pull request, #208124. 🤔

@ToasterUwU
Copy link
Member

I appreciate the effort, im new to NixOS and just installed cura only to realize its still on 4.x while we already have 5.6 .-.
Im sadly no cmake magician either, so i cant really help much. But i hope this gets updated soon, and please not only to 5.1, but 5.6

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@aucub aucub closed this Dec 19, 2024
@aucub aucub reopened this Jan 22, 2025
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 22, 2025
@LunNova
Copy link
Member Author

LunNova commented Jan 22, 2025

Oh, closing this was fine. I gave up on trying to tidy this up properly. 😅

@LunNova LunNova closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cura needs updated to 5.1
6 participants