-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cura 5.2.1 #208124
Draft
nh2
wants to merge
7
commits into
NixOS:master
Choose a base branch
from
nh2:cura-5.2.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Cura 5.2.1 #208124
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5e40f38
curaengine: Reformat library lists
nh2 9d5a500
cura, curaengine, python3Packages.libarcus, python3Packages.libsavita…
nh2 ce3168c
WIP: Make curaengine build. Lots of commented-out stuff, and small cu…
nh2 468c6fe
WIP: libarcus compiles at 5.2.0
nh2 248418f
WIP: uranium builds at 5.2.0
nh2 34ba8ec
WIP: curaengine builds at 5.2.1
nh2 acfdd7d
WIP: Trying to build cura 5.2.1. Does not work yet because there's no…
nh2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
## Finds the Stb utility library on your computer. | ||
# | ||
# This script exports the following parameters for use if you find the Stb | ||
# package: | ||
# - Stb_FOUND: Whether Stb has been found on your computer. | ||
# - Stb_INCLUDE_DIRS: The directory where the header files of Stb are located. | ||
|
||
find_package(PkgConfig QUIET) | ||
pkg_check_modules(PC_Stb QUIET Stb) | ||
|
||
find_path(Stb_INCLUDE_DIRS stb_image_resize.h #Search for something that is a little less prone to false positives than just stb.h. | ||
HINTS ${PC_Stb_INCLUDEDIR} ${PC_Stb_INCLUDE_DIRS} | ||
PATHS "$ENV{PROGRAMFILES}" "$ENV{PROGRAMW6432}" "/usr/include" | ||
PATH_SUFFIXES include/stb stb include | ||
) | ||
|
||
include(FindPackageHandleStandardArgs) | ||
find_package_handle_standard_args(Stb DEFAULT_MSG Stb_INCLUDE_DIRS) | ||
|
||
mark_as_advanced(Stb_INCLUDE_DIRS) | ||
|
||
if(Stb_FOUND) | ||
message(STATUS "Found Stb installation at: ${Stb_INCLUDE_DIRS}") | ||
add_library(Stb::Stb INTERFACE IMPORTED) | ||
set_target_properties(Stb::Stb PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${Stb_INCLUDE_DIRS}) | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover debug code?Missed that this isn't ready for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've only done the Cura dependencies, not Cura itself.