Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove float parsing section of NOTES.md #225

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Remove float parsing section of NOTES.md #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 1 addition & 45 deletions NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,50 +2,6 @@

documenting the current status of affairs

## float formatter

FF:

```js
console.log("%f", 23)
23.000000
```

Chrome:

```js
console.log("%f", 23)
23
```

FF:

```
console.log('bjoern and robert are born on the %fst dec', 1.234)
bjoern and robert are born on the 1.234000st dec
```

Chrome:

```
console.log('bjoern and robert are born on the %fst dec', 1.234)
bjoern and robert are born on the 1.234st dec
````

FF:

```js
console.log("%f", null)
0.000000
```

Chrome:

```js
console.log("%f", null)
NaN
```

## integer formatter

FF:
Expand Down Expand Up @@ -456,4 +412,4 @@ Edge:
console.time({ toString() { throw new Error("Farolino") } }) // toString called, no error thrown, no timer started
```

Bug: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11201116/
Bug: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11201116/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't know what to make of this line diff. Maybe a platform-specific EOF or line break change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty normal with the last line of the file when the newline is missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Anyways, I'd like for you to take a look at this and let me know what you think