Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove float parsing section of NOTES.md #225

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Remove float parsing section of NOTES.md #225

merged 1 commit into from
Aug 9, 2023

Conversation

domfarolino
Copy link
Member

This PR makes some progress on #181 by removing the "Float parsing" section of NOTES.md. Firefox and sometimes Safari deviate from the spec in a couple of ways, so I've filed bugs with their implementation to track the difference:

@domfarolino domfarolino requested a review from terinjokes August 1, 2023 20:31
Bug: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11201116/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't know what to make of this line diff. Maybe a platform-specific EOF or line break change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty normal with the last line of the file when the newline is missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Anyways, I'd like for you to take a look at this and let me know what you think

@domfarolino
Copy link
Member Author

@terinjokes could you take a look?

@domfarolino domfarolino merged commit a7b2c46 into main Aug 9, 2023
@domfarolino domfarolino deleted the pare-notes branch August 9, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants