Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No-Ticket] - Multiple Fixes #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 29 additions & 22 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,24 +1,31 @@
{
"env": {
"browser": true,
"es2021": true
},
"extends": [
"eslint:recommended",
"plugin:react/recommended"
],
"parserOptions": {
"ecmaFeatures": {
"jsx": true
"env": {
"browser": true,
"es2021": true
},
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": [
"react"
],
"rules": {
"react/jsx-uses-react": "error",
"react/jsx-uses-vars": "error"
}
}
"extends": [
"plugin:react/recommended",
"airbnb"
],
"parserOptions": {
"ecmaFeatures": {
"jsx": true
},
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": [
"react"
],
"rules":{
"no-restricted-syntax": ["error", "FunctionExpression", "WithStatement", "BinaryExpression[operator='in']"],
"react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }],
"react/function-component-definition": [
2,
{
"namedComponents": "arrow-function",
"unnamedComponents": "arrow-function"
}
]
}
}
71 changes: 9 additions & 62 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,70 +1,17 @@
# Getting Started with Create React App
# Getting Started with Amazon Clone App

This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app).
# User Have to Login in the App

## Available Scripts
Landing Page of App is login Page Where user have to enter login details

In the project directory, you can run:
# Dashboard Page

### `npm start`
if user Logged in Succesfully then Dashboard page will display

Runs the app in the development mode.\
Open [http://localhost:3000](http://localhost:3000) to view it in your browser.
# Dashboard Page Content

The page will reload when you make changes.\
You may also see any lint errors in the console.
1 There is NavBar Which is Dispalying user Name and Buttons

### `npm test`
2 Firstly on Upper there is slidder in Which all movies are displaying

Launches the test runner in the interactive watch mode.\
See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information.

### `npm run build`

Builds the app for production to the `build` folder.\
It correctly bundles React in production mode and optimizes the build for the best performance.

The build is minified and the filenames include the hashes.\
Your app is ready to be deployed!

See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information.

### `npm run eject`

**Note: this is a one-way operation. Once you `eject`, you can't go back!**

If you aren't satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.

Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you're on your own.

You don't have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't customize it when you are ready for it.

## Learn More

You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).

To learn React, check out the [React documentation](https://reactjs.org/).

### Code Splitting

This section has moved here: [https://facebook.github.io/create-react-app/docs/code-splitting](https://facebook.github.io/create-react-app/docs/code-splitting)

### Analyzing the Bundle Size

This section has moved here: [https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size](https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size)

### Making a Progressive Web App

This section has moved here: [https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app](https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app)

### Advanced Configuration

This section has moved here: [https://facebook.github.io/create-react-app/docs/advanced-configuration](https://facebook.github.io/create-react-app/docs/advanced-configuration)

### Deployment

This section has moved here: [https://facebook.github.io/create-react-app/docs/deployment](https://facebook.github.io/create-react-app/docs/deployment)

### `npm run build` fails to minify

This section has moved here: [https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify](https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify)
3 Below Slidder there is Card which is Displaying all Movies
50 changes: 45 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 9 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"@testing-library/react": "^13.3.0",
"@testing-library/user-event": "^13.5.0",
"bootstrap": "^5.1.3",
"prop-types": "^15.8.1",
"react": "^18.2.0",
"react-bootstrap": "^2.4.0",
"react-dom": "^18.2.0",
Expand All @@ -16,14 +17,16 @@
"react-router-dom": "^6.3.0",
"react-scripts": "5.0.1",
"redux": "^4.2.0",
"sweetalert": "^2.1.2",
"web-vitals": "^2.1.4"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject",
"lint": "eslint src/**/*.js"
"lint": "eslint src/**/*.js",
"lint-fix": "eslint src/**/*.js --fix"
},
"eslintConfig": {
"extends": [
Expand All @@ -44,14 +47,14 @@
]
},
"devDependencies": {
"eslint": "^8.20.0",
"eslint": "^7.32.0 || ^8.2.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vishalguptag - Please add pre-commit command's in package.json file.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okkk sir

"eslint-config-airbnb": "^19.0.4",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-jsx-a11y": "^6.6.1",
"eslint-plugin-import": "^2.25.3",
"eslint-plugin-jsx-a11y": "^6.5.1",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-react": "^7.30.1",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react": "^7.28.0",
"eslint-plugin-react-hooks": "^4.3.0",
"prettier": "2.7.1"
}
}
6 changes: 0 additions & 6 deletions src/.prettierrc.json

This file was deleted.

11 changes: 0 additions & 11 deletions src/Actions/index.js

This file was deleted.

2 changes: 1 addition & 1 deletion src/AdminDetail/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// Login Details of the user
// Login Constants of the user
export const adminUser = 'vishal';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vishalguptag - Please comment in a bit of detail. For example: Please use below username and password for login.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okkk sir

export const adminPass = 'admin@123';
23 changes: 13 additions & 10 deletions src/App.js
Original file line number Diff line number Diff line change
@@ -1,23 +1,26 @@
import React, { useState } from 'react';
import React, { useState, useMemo } from 'react';
// import Packages

import { userContext } from './Context/UserContext';
import userContext from './Context/UserContext';
// imported Created Context

import Routing from './Routing';
import Auth from './Authrization';
// imported Requried Componenets

function App() {
//state for the context
const [loginData,setLoginData] = useState({
username : '',
password : '',
loggedIn : false
const App = () => {
// state for the context
const [loginData, setLoginData] = useState({
username: '',
password: '',
loggedIn: false,
});
const AuthContext = useMemo(() => ({
loginData, setLoginData,
}));
return (
// Providing the context value to our App
<userContext.Provider value={{loginData,setLoginData}}>
<userContext.Provider value={AuthContext}>
<div className="App">
{/* Use for Authrization */}
<Auth />
Expand All @@ -27,6 +30,6 @@ function App() {
</div>
</userContext.Provider>
);
}
};

export default App;
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
/* sub-container of Slidder */
.posterOfSlidder{
height: 600px;
}
/* mainn container of slidder */
.mainDivOfSlidder{
height: 600px;
}
Loading
Loading