Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No-Ticket] - Multiple Fixes #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

vishal-gupta-252310
Copy link
Owner

list of fixes descibed below:

  1. Fix Eslint Error that can't visible in vs code.
  2. Make dynamic Routes instead of Static Routes.
  3. Implement Central Authentication Layer for Route Chage.

@sachiv-logiciel
Copy link

@Vishalguptag - Can you please tell me why u commit AmazonPrime.zip file in code?

@@ -44,14 +47,14 @@
]
},
"devDependencies": {
"eslint": "^8.20.0",
"eslint": "^7.32.0 || ^8.2.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vishalguptag - Please add pre-commit command's in package.json file.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okkk sir

@@ -1,3 +1,3 @@
// Login Details of the user
// Login Constants of the user

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vishalguptag - Please comment in a bit of detail. For example: Please use below username and password for login.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okkk sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants