-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dev): more tricky clippy fixes #1237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pront
commented
Jan 28, 2025
@@ -84,14 +84,15 @@ fn parse_layer(value: &RawValue, remaining_depth: u8) -> std::result::Result<Jso | |||
|
|||
fn validate_depth(value: Value) -> ExpressionResult<u8> { | |||
let res = value.try_integer()?; | |||
let res = u8::try_from(res).map_err(|e| e.to_string())?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already check for [1, 128] below so this is not a breaking change.
jszwedko
approved these changes
Jan 28, 2025
src/stdlib/parse_etld.rs
Outdated
Comment on lines
140
to
141
#[allow(clippy::cast_sign_loss, clippy::cast_possible_truncation)] | ||
// TODO consider removal options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit I'd find this slightly easier to read if the TODO was above the clippy allow.
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-changelog
Changes in this PR do not need user-facing explanations in the release changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 3. Properly fixing the code around casts would be a breaking change. For now, I just removed the global
#[allow(...)]
blocks so that we don't introduce new code with these problems.Previous PR: #1236
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool write
and commit the changes. More details here.References