Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dev): fix deprecations #1238

Merged
merged 2 commits into from
Jan 29, 2025
Merged

chore(dev): fix deprecations #1238

merged 2 commits into from
Jan 29, 2025

Conversation

pront
Copy link
Member

@pront pront commented Jan 29, 2025 •
edited
Loading

Summary

Part 4.

Previous PR: #1237

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

References

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 29, 2025
@pront pront force-pushed the pront/deny-deprecations branch from 87a3ab0 to 86d1859 Compare January 29, 2025 17:07
@pront pront force-pushed the pront/deny-deprecations branch from 86d1859 to e4e1d82 Compare January 29, 2025 17:36
@pront pront marked this pull request as ready for review January 29, 2025 17:36
@pront pront requested a review from jszwedko January 29, 2025 17:36
@pront pront enabled auto-merge January 29, 2025 19:03
@pront pront added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 6b82a86 Jan 29, 2025
14 checks passed
@pront pront deleted the pront/deny-deprecations branch January 29, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pront @jszwedko