Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Replace sidecar-browsershot.layer-config with sidecar-browsershot.layers-config #103

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

stefanzweifel
Copy link
Owner

I was never a big fan of the sidecar-browsershot.layer config. It only allowed users to add 1 additional layer to the function. That's quite limiting.

And since #85, sidecar-browsershot relies on multiple AWS layers. It's more than fitting to update the config.
User can now change the entire layers-"stack" at their will.

To make things simpler for me, if a user does that, they are also responsible to include the appropriate chromium layers.

@stefanzweifel stefanzweifel merged commit 8b7de6d into main Dec 29, 2023
6 checks passed
@stefanzweifel stefanzweifel deleted the v2/layers-config branch December 29, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant