Support Browsershot v4 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jubeki
reviewed
Dec 29, 2023
Co-authored-by: Julius Kiekbusch <[email protected]>
There was a problem hiding this comment.
Thanks @freekmurze for the PR.
Will actually tag a new major version for this, as I've prepared some breaking changes in #106 and #103.
|
GitHub Actions fail as PRs from contributors don't have access to the AWS secrets. Will test the PR locally, after I've fixed my local setup. |
|
👍 I'll also mention sidecar-browsershot in the docs of laravel-pdf: https://spatie.be/docs/laravel-pdf/v1/advanced-usage/generating-pdfs-on-aws-lambda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've released Browsershot v4. It's a maintenance release where we did some cleanups of the internals, but the API remained the same. The dependency on spatie/image is now optional, and at least v3 is required. PHP 8.2 is required.
This PR makes sidecar-browsershot compatible with Browsershot v4. I only made the minimal changes. Optionally, you could also upgrade the codebase of your package to use PHP 8.2 features.