-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pip with uv for test workflow #877
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 48 48
Lines 7388 7388
=======================================
Hits 6791 6791
Misses 597 597 |
I'll give a try to |
I'm having problems with optional dependencies. It seems that they are not correctly cached. |
Ok I made it work. Caching doesn't help with pre-built wheels, re-downloading every time is as fast (also explained here https://github.com/astral-sh/setup-uv#disable-cache-pruning). I will disable the cache. This PR will still bring a 4-fold decrease in the time required to setup the env. |
I tried using
I therefore went back to |
CC @timtreis (worth moving to |
Giving a try to using
uv
instead ofpip
for the test workflow. I did't edit the release and docker workflows since they are run rarely and trying to make them faster would not pay off.I took inspiration from https://github.com/vitessce/vitessce-python/pull/390/files. Note that I removed the
pip
caching mechanism in this commit fac7848. It could be that havinguv
+ caching leads to better results.