Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter x #324

Merged
merged 6 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/release-notes/0.12.0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
### 0.12.0 {small}`the-future`

```{rubric} Features
```
* Updates `pp.filter_genes` & `pp.filter_cells` to be closer to the `scanpy` implementation {pr}`324` {smaller}`S Dicks`

```{rubric} Performance
```

```{rubric} Bug fixes
```

```{rubric} Misc
```
4 changes: 4 additions & 0 deletions docs/release-notes/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

# Release notes

## Version 0.12.0
```{include} /release-notes/0.12.0.md
```

## Version 0.11.0
```{include} /release-notes/0.11.1.md
```
Expand Down
6 changes: 2 additions & 4 deletions src/rapids_singlecell/preprocessing/_scrublet/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,8 @@ def _run_scrublet(ad_obs: AnnData, ad_sim: AnnData | None = None):
# counts and simulating doublets

if ad_sim is None:
pp.filter_genes(ad_obs, min_count=3, verbose=False)
pp.filter_cells(
ad_obs, min_count=3, qc_var="n_genes_by_counts", verbose=False
)
pp.filter_genes(ad_obs, min_cells=3, verbose=False)
pp.filter_cells(ad_obs, min_genes=3, verbose=False)

# Doublet simulation will be based on the un-normalised counts, but on the
# selection of genes following normalisation and variability filtering. So
Expand Down
Loading
Loading