Update filter x #324
Open
Update filter x #324
+334
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you highlight what you changed? Did some behavior change? |
|
@ilan-gold so basically before I did something slightly different than what scanpy does in those functions. Now they do exactly the same thing. I had to pass a qc_var and than I took the value from obs or var and did not recalculate the values |
|
but have the results changed? like do you still filter out the same genes/cells for the "same" arguments? that's not clear to me |
|
@ilan-gold The results have not changed but the syntax has. So its a breaking change. |
Comment on lines
-57
to
+64
| qc_var: str = "n_cells_by_counts", | ||
| min_count: int = None, | ||
| max_count: int = None, | ||
| min_counts: int | None = None, | ||
| min_cells: int | None = None, | ||
| max_counts: int | None = None, | ||
| max_cells: int | None = None, | ||
| inplace: bool = True, |
There was a problem hiding this comment.
@ilan-gold these API changes are what this PR is about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.