Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builtins): implement suspend #311

Merged
merged 1 commit into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions brush-core/src/builtins.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ mod return_;
mod set;
mod shift;
mod shopt;
#[cfg(unix)]
mod suspend;
mod test;
mod times;
mod trap;
Expand Down
3 changes: 2 additions & 1 deletion brush-core/src/builtins/factory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,8 @@ pub(crate) fn get_default_builtins(
m.insert("printf".into(), builtin::<printf::PrintfCommand>());
m.insert("shopt".into(), builtin::<shopt::ShoptCommand>());
m.insert("source".into(), special_builtin::<dot::DotCommand>());
#[cfg(unix)]
m.insert("suspend".into(), builtin::<suspend::SuspendCommand>());
m.insert("test".into(), builtin::<test::TestCommand>());
m.insert("[".into(), builtin::<test::TestCommand>());
m.insert("typeset".into(), builtin::<declare::DeclareCommand>());
Expand All @@ -284,7 +286,6 @@ pub(crate) fn get_default_builtins(
m.insert("history".into(), builtin::<unimp::UnimplementedCommand>());
m.insert("logout".into(), builtin::<unimp::UnimplementedCommand>());
m.insert("readarray".into(), builtin::<unimp::UnimplementedCommand>());
m.insert("suspend".into(), builtin::<unimp::UnimplementedCommand>());
}

//
Expand Down
33 changes: 33 additions & 0 deletions brush-core/src/builtins/suspend.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
use clap::Parser;
use std::io::Write;

use crate::{builtins, commands, error};

/// Suspend the shell.
#[derive(Parser)]
pub(crate) struct SuspendCommand {
/// Force suspend login shells.
#[arg(short = 'f')]
force: bool,
}

impl builtins::Command for SuspendCommand {
async fn execute(
&self,
context: commands::ExecutionContext<'_>,
) -> Result<builtins::ExitCode, error::Error> {
if context.shell.options.login_shell && !self.force {
writeln!(context.stderr(), "login shell cannot be suspended")?;
return Ok(builtins::ExitCode::InvalidUsage);
}

#[allow(clippy::cast_possible_truncation)]
#[allow(clippy::cast_possible_wrap)]
crate::sys::signal::kill_process(
std::process::id() as i32,
crate::traps::TrapSignal::Signal(nix::sys::signal::SIGSTOP),
)?;

Ok(builtins::ExitCode::Success)
}
}
Loading