Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builtins): implement suspend #311

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat(builtins): implement suspend #311

merged 1 commit into from
Jan 9, 2025

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Jan 9, 2025

No description provided.

@reubeno reubeno requested a review from Copilot January 9, 2025 07:17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

brush-core/src/builtins/suspend.rs:20

  • The error message could be more informative. Consider changing it to: "Cannot suspend a login shell without the force option enabled".
writeln!(context.stderr(), "login shell cannot be suspended")?
Copy link

github-actions bot commented Jan 9, 2025

Test Results

    2 files      9 suites   1m 17s ⏱️
  574 tests   574 ✅ 0 💤 0 ❌
1 134 runs  1 134 ✅ 0 💤 0 ❌

Results for commit a8bb996.

Copy link

github-actions bot commented Jan 9, 2025

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 19.43 μs 19.38 μs -0.05 μs ⚪ Unchanged
eval_arithmetic 0.44 μs 0.42 μs -0.02 μs ⚪ Unchanged
expand_one_string 2.34 μs 2.37 μs 0.02 μs ⚪ Unchanged
for_loop 63.96 μs 64.10 μs 0.14 μs ⚪ Unchanged
function_call 5.08 μs 5.00 μs -0.07 μs ⚪ Unchanged
instantiate_shell 62.26 μs 62.33 μs 0.08 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 28647.31 μs 27343.24 μs -1304.07 μs 🟢 -4.55%
parse_bash_completion 2873.37 μs 2861.82 μs -11.56 μs ⚪ Unchanged
parse_sample_script 4.41 μs 4.48 μs 0.07 μs 🟠 +1.66%
run_echo_builtin_command 22.40 μs 22.01 μs -0.39 μs ⚪ Unchanged
run_one_external_command 1948.78 μs 2240.28 μs 291.49 μs 🟠 +14.96%

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/builtins/factory.rs 🟢 82.28% 🟢 82.35% 🟢 0.07%
Overall Coverage 🟢 74.42% 🟢 74.34% 🔴 -0.08%

Minimum allowed coverage is 70%, this run produced 74.34%� -0.07%** |

Minimum allowed coverage is 70%, this run produced 76.69%

@reubeno reubeno merged commit 972ecf9 into main Jan 9, 2025
17 checks passed
@reubeno reubeno deleted the suspend branch January 9, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant