Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update critical banner dismiss section #913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update critical banner dismiss section #913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/components/banner.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ Use the following as a guideline:
>
<div>

Critical banners can't be dismissable. They are mostly used for errors which need to be resolved. As a result you can only get rid of a critical banner by resolving the error. If used to warn about destructive actions, the banner should also not be dismissable.
You should try to avoid dismissable critical banners. They are mostly used for errors which need to be resolved. As a result, the user resolving the error to get rid of the critical banner. If used to warn about destructive actions, the banner should also not be dismissable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"As a result, the user resolving the error to get rid of the critical banner."

I think this sentence reads a little weird, what is it trying to say?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You should try to avoid dismissable critical banners. They are mostly used for errors which need to be resolved. As a result, the user resolving the error to get rid of the critical banner. If used to warn about destructive actions, the banner should also not be dismissable.
Critical banners communicate an error which the user must resolve in order for the banner to disappear. In certain cases, the banner may be dismissible when notifying the user of a failed action. If used to warn about destructive actions, the banner should also not be dismissible.

Took a stab at this, curious what you think of the wording 🤔


If the error must be resolved on a different page, use an action that directs the user to the page where the error can be resolved.

Expand Down
Loading