Update critical banner dismiss section #913
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update critical banner dismiss section
francinelucca
requested changes
Jan 22, 2025
| @@ -200,7 +200,7 @@ Use the following as a guideline: | |||
| > | |||
| <div> | |||
|
|
|||
| Critical banners can't be dismissable. They are mostly used for errors which need to be resolved. As a result you can only get rid of a critical banner by resolving the error. If used to warn about destructive actions, the banner should also not be dismissable. | |||
| You should try to avoid dismissable critical banners. They are mostly used for errors which need to be resolved. As a result, the user resolving the error to get rid of the critical banner. If used to warn about destructive actions, the banner should also not be dismissable. | |||
There was a problem hiding this comment.
"As a result, the user resolving the error to get rid of the critical banner."
I think this sentence reads a little weird, what is it trying to say?
joshblack
reviewed
Jan 22, 2025
| @@ -200,7 +200,7 @@ Use the following as a guideline: | |||
| > | |||
| <div> | |||
|
|
|||
| Critical banners can't be dismissable. They are mostly used for errors which need to be resolved. As a result you can only get rid of a critical banner by resolving the error. If used to warn about destructive actions, the banner should also not be dismissable. | |||
| You should try to avoid dismissable critical banners. They are mostly used for errors which need to be resolved. As a result, the user resolving the error to get rid of the critical banner. If used to warn about destructive actions, the banner should also not be dismissable. | |||
There was a problem hiding this comment.
Suggested change
| You should try to avoid dismissable critical banners. They are mostly used for errors which need to be resolved. As a result, the user resolving the error to get rid of the critical banner. If used to warn about destructive actions, the banner should also not be dismissable. | |
| Critical banners communicate an error which the user must resolve in order for the banner to disappear. In certain cases, the banner may be dismissible when notifying the user of a failed action. If used to warn about destructive actions, the banner should also not be dismissible. |
Took a stab at this, curious what you think of the wording 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update critical banner dismiss section