Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rs-workspace): add intermediary state checkpoints #29

Merged
merged 3 commits into from
Oct 3, 2024
Merged

fix(rs-workspace): add intermediary state checkpoints #29

merged 3 commits into from
Oct 3, 2024

Conversation

DariuszPorowski
Copy link
Member

📥 Pull Request

❓ What are you trying to address

This pull request introduces a checkpoint mechanism for saving intermediary states in the fabric_workspace resource, which helps in improving the reliability of state management during create and update operations.

✨ Description of new changes

  • internal/services/workspace/resource_workspace.go:
    • func (r *resourceWorkspace) Create(ctx context.Context, req resource.CreateReque): Added intermediary state save checkpoints after creating the resource and before setting the final state.
    • func (r *resourceWorkspace) Update(ctx context.Context, req resource.UpdateReque): Introduced an intermediary variable to hold the state at different stages of the update process, and added checkpoints to save this intermediary state.

@DariuszPorowski DariuszPorowski requested a review from a team as a code owner October 3, 2024 07:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

Changelog Preview

v0.1.0-dev - October 03, 2024

🪲 Fixed

  • #29 Add intermediary state checkpoints for fabric_workspace Resource

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 80% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 62% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 65% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider 86% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 70% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/domain 41% 0 ➖
github.com/microsoft/terraform-provider-fabric/internal/services/environment 86% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 84% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 78% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 82% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/spark 74% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 84% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0 ✔
Summary 74% (3593 / 4881) 0 ✔

Minimum allowed line rate is 40%

@DariuszPorowski DariuszPorowski added this to the 2024-10 milestone Oct 3, 2024
hattan
hattan approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@hattan hattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DariuszPorowski DariuszPorowski merged commit d38f34f into main Oct 3, 2024
22 checks passed
@DariuszPorowski DariuszPorowski deleted the fix/rs_workspace branch October 3, 2024 19:55
@github-actions github-actions bot mentioned this pull request Oct 4, 2024
Merged
This was referenced Oct 11, 2024
Merged
Merged
@DariuszPorowski DariuszPorowski mentioned this pull request Nov 13, 2024
Merged
DariuszPorowski added a commit that referenced this pull request Nov 13, 2024
@DariuszPorowski
feat(release): v0.1.0-beta.5 (#87)
bb1d418 
## v0.1.0-beta.5 - November 13, 2024

### ✨ Added

*
[#46](#46)
New read-only properties in the `fabric_workspace` Resource/Data-Source:
`capacity_region`, `onelake_endpoints`

### 💫 Changed

*
[#32](#32)
Moved from az rest to fabric az-cli extension in the bash examples
*
[#46](#46)
Updated docs for possible values for `state` and `region` in the
`fabric_capacity` Data-Source.

### 🪲 Fixed

*
[#29](#29)
Add intermediary state checkpoints for `fabric_workspace` Resource
*
[#47](#47)
`fabric_lakehouse` Resource creation failed when
`configuration.enable_schemas` has been set to `false`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hattan hattan hattan approved these changes

Assignees

@DariuszPorowski DariuszPorowski

Labels
None yet
Projects
None yet
Milestone
2024-10
Development

Successfully merging this pull request may close these issues.
2 participants
@DariuszPorowski @hattan