Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace-capacity): add additional properties for region and 1lake endpoints #46

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

DariuszPorowski
Copy link
Member

πŸ“₯ Pull Request

❓ What are you trying to address

This pull request includes several updates to the documentation and internal codebase to provide more detailed information about capacity and workspace attributes, including possible values for various properties.

✨ Description of new changes

Documentation Updates:

  • Added possible values for region and state attributes in docs/data-sources/capacities.md.
  • Added possible values for region and state attributes in docs/data-sources/capacity.md.
  • Added possible values for capacity_assignment_progress and capacity_region attributes, and included a nested schema for onelake_endpoints in docs/data-sources/workspace.md. [1] [2]
  • Added possible values for capacity_assignment_progress and capacity_region attributes, and included a nested schema for onelake_endpoints in docs/resources/workspace.md. [1] [2]

Codebase Updates:

  • Updated data_capacities.go and data_capacity.go to include possible values for region and state attributes. [1] [2]
  • Updated data_workspace.go to include possible values for capacity_region and capacity_assignment_progress attributes, and added a nested attribute for onelake_endpoints.
  • Updated models.go to include capacity_region and onelake_endpoints attributes in the baseWorkspaceInfoModel struct and added corresponding setter functions. [1] [2] [3]
  • Updated resource_workspace.go to include possible values for capacity_region and capacity_assignment_progress attributes, and added a nested attribute for onelake_endpoints.
  • Updated fabric_workspace.go to include capacity_region and onelake_endpoints in the NewRandomWorkspaceInfo function.

Copy link

github-actions bot commented Oct 11, 2024

Changelog Preview

v0.1.0-dev - November 12, 2024

✨ Added

  • #46 New read-only properties in the fabric_workspace Resource/Data-Source: capacity_region, onelake_endpoints

πŸ’« Changed

  • #32 Moved from az rest to fabric az-cli extension in the bash examples
  • #46 Updated docs for possible values for state and region in the fabric_capacity Data-Source.

πŸͺ² Fixed

  • #29 Add intermediary state checkpoints for fabric_workspace Resource
  • #47 fabric_lakehouse Resource creation failed when configuration.enable_schemas has been set to false

Copy link

github-actions bot commented Oct 11, 2024

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 80% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 62% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 65% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider 86% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 70% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/domain 41% 0 βž–
github.com/microsoft/terraform-provider-fabric/internal/services/environment 86% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 84% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 78% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 83% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/spark 74% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 84% 0 βœ”
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0 βœ”
Summary 74% (3605 / 4890) 0 βœ”

Minimum allowed line rate is 40%

@DariuszPorowski DariuszPorowski added documentation Improvements or additions to documentation tf/data-source Terraform Data-Source tf/resource Terraform Resource feature New feature or request labels Oct 12, 2024
@DariuszPorowski DariuszPorowski added this to the 2024-10 milestone Oct 12, 2024
@DariuszPorowski DariuszPorowski merged commit b7160ef into main Nov 12, 2024
22 checks passed
@DariuszPorowski DariuszPorowski deleted the feat/ws-cap-details branch November 12, 2024 20:16
DariuszPorowski added a commit that referenced this pull request Nov 13, 2024
## v0.1.0-beta.5 - November 13, 2024

### ✨ Added

*
[#46](#46)
New read-only properties in the `fabric_workspace` Resource/Data-Source:
`capacity_region`, `onelake_endpoints`

### πŸ’« Changed

*
[#32](#32)
Moved from az rest to fabric az-cli extension in the bash examples
*
[#46](#46)
Updated docs for possible values for `state` and `region` in the
`fabric_capacity` Data-Source.

### πŸͺ² Fixed

*
[#29](#29)
Add intermediary state checkpoints for `fabric_workspace` Resource
*
[#47](#47)
`fabric_lakehouse` Resource creation failed when
`configuration.enable_schemas` has been set to `false`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request tf/data-source Terraform Data-Source tf/resource Terraform Resource
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants