Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(domain): enable spn support #286

Merged
merged 6 commits into from
Mar 6, 2025
Merged

feat(domain): enable spn support #286

merged 6 commits into from
Mar 6, 2025

Conversation

DariuszPorowski
Copy link
Member

📥 Pull Request

❓ What are you trying to address

This pull request introduces support for Service Principal (SPN) authentication for various domain-related resources and data sources. The changes span across documentation updates, configuration files, and test cases.

Copy link

github-actions bot commented Mar 5, 2025

Changelog Preview

v0.1.0-dev - March 06, 2025

💫 Changed

  • #286 SPN is now supported for Domain resources/data-sources

Copy link

github-actions bot commented Mar 6, 2025

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 89% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 69% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 80% 0
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 82% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 64% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 87% 0
github.com/microsoft/terraform-provider-fabric/internal/provider 85% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/client 78% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 69% 0
github.com/microsoft/terraform-provider-fabric/internal/services/activator 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/domain 71% 0
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 93% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/graphqlapi 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/spark 75% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sqldatabase 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0
Summary 79% (4376 / 5532) 0

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 81.71%. Comparing base (a16d3a2) to head (abee0b6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ervices/domain/resource_domain_role_assignments.go 65.00% 7 Missing ⚠️
internal/services/domain/data_domain.go 50.00% 1 Missing ⚠️
...rvices/domain/data_domain_workspace_assignments.go 50.00% 1 Missing ⚠️
internal/services/domain/data_domains.go 50.00% 1 Missing ⚠️
internal/services/domain/resource_domain.go 50.00% 1 Missing ⚠️
...es/domain/resource_domain_workspace_assignments.go 50.00% 1 Missing ⚠️
...ernal/services/workspace/resource_workspace_git.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   79.50%   81.71%   +2.21%     
==========================================
  Files         165      165              
  Lines       13465    13454      -11     
==========================================
+ Hits        10705    10994     +289     
+ Misses       2755     2455     -300     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants