-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kql_database): deprecate token and add token_wo #281
base: main
Are you sure you want to change the base?
Conversation
Minimum allowed line rate is |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 79.50% 79.37% -0.13%
==========================================
Files 165 165
Lines 13465 13326 -139
==========================================
- Hits 10705 10578 -127
+ Misses 2755 2743 -12
Partials 5 5 ☔ View full report in Codecov by Sentry. |
568729e
to
a765df2
Compare
@@ -104,7 +104,7 @@ func (r *ResourceFabricItemConfigProperties[Ttfprop, Titemprop, Ttfconfig, Titem | |||
reqCreate.setDescription(plan.Description) | |||
reqCreate.setType(r.Type) | |||
|
|||
creationPayload, diags := getCreationPayload(ctx, plan.Configuration, r.CreationPayloadSetter) | |||
creationPayload, diags := getCreationPayload(ctx, config.Configuration, r.CreationPayloadSetter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getCreationPayload takes Tconfiguration as an argument, how did it work without it?
because the property setter uses the type specific configuration properties , and they exist also in the plan?
EventhouseID customtypes.UUID `tfsdk:"eventhouse_id"` | ||
InvitationToken types.String `tfsdk:"invitation_token"` | ||
InvitationTokenWO types.String `tfsdk:"invitation_token_wo"` | ||
InvitationTokenWOVersion types.Int32 `tfsdk:"invitation_token_wo_version"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the invitation token is a part of the creation payload, meaning that currently it cannot be update. why is the versioning needed?
I think it's only relevant for read only & updateable properties.
@@ -69,18 +71,57 @@ func getResourceKQLDatabaseConfigurationAttributes() map[string]schema.Attribute | |||
MarkdownDescription: "Invitation token to follow the source database. Only allowed when `database_type` is `" + string(fabkqldatabase.TypeShortcut) + "`.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we plan to depricate it?
will we write deprication date?
do we have any traces for invitation_token usage vs _wo usage?
📥 Pull Request
❓ What are you trying to address
https://developer.hashicorp.com/terraform/plugin/framework/resources/write-only-arguments
https://developer.hashicorp.com/terraform/language/resources/ephemeral/write-only