Fix Editor Tour in French #10411
Merged
Fix Editor Tour in French #10411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/pxt-arcade#6717
There were two issues happening causing the bug:
Firstly, some of the strings (location & highlight) should not be translated but were translated. They're used by the code to reference positions and elements in the DOM respectively, so when they're in french, they don't map to anything. I've gone through and removed the translations in crowdin.
Secondly, some of the properties had spaces before the semicolon, i.e:
location : center, and that was being left in for the property name. For these, I think it's safe to trim the string, hence this PR.