Skip to content

Commit

Permalink
Fix Editor Tour in French (#10411)
Browse files Browse the repository at this point in the history
There were two issues happening causing the bug:

Firstly, some of the strings (location & highlight) should not be translated but were translated. They're used by the code to reference positions and elements in the DOM respectively, so when they're in french, they don't map to anything. I've gone through and removed the translations in crowdin.

Secondly, some of the properties had spaces before the semicolon, i.e: location : center, and that was being left in for the property name. For these, I think it's safe to trim the string, hence this PR.
  • Loading branch information
thsparks authored Mar 7, 2025
1 parent 0bdd21a commit c9fef48
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pxtlib/markdownMetadataParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ namespace pxt {
}
}

currentKey = keyMatch[1].toLowerCase();
currentKey = keyMatch[1].trim().toLowerCase();
currentValue = keyMatch[2];
}
else if (currentKey) {
Expand Down Expand Up @@ -141,4 +141,4 @@ namespace pxt {
}
return 0;
}
}
}

0 comments on commit c9fef48

Please sign in to comment.