Allow writing contents when deploying #625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you explain the differences between the two approaches? |
This one is very explicit about what it's doing, i.e., copy files from one directory to a specific branch. The other one (#623) deploys to Github pages and relies more on the settings in the repository to do what is necessary so it's more difficult to debug. The error I was running into last can be found in https://github.com/masterleinad/kokkos-core-wiki/actions/runs/13119609186. |
JBludau
reviewed
Feb 4, 2025
| with: | ||
| name: documentation.tar.gz | ||
| path: ${{ env.docs-directory }}/generated_docs | ||
| # .nojekyll file is needed for GitHub Pages to know it's getting a ready webpage |
There was a problem hiding this comment.
hmm did you accidentally delete half the comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #623. Fixes deplotibng, also see https://github.com/JamesIves/github-pages-deploy-action?tab=readme-ov-file#getting-started-airplane. The
GITHUB_TOKENused only has read permissions and we have to explicitly grant write permissions in this workflow.