Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action to deploy to GitHub pages #623

Merged
merged 11 commits into from
Feb 4, 2025

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Jan 30, 2025

This is an attempt to fix the permissions error on the last merge. The code is inspired from https://github.com/actions/upload-pages-artifact

This is an attempt to fix the permissions error on the last merge.
The code is inspired from https://github.com/actions/upload-pages-artifact
Copy link
Contributor

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build stage seems to be working. Did you check the deploy stage?

Copy link
Contributor

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a drive by typo

@JBludau
Copy link
Contributor

JBludau commented Feb 4, 2025

If this one works I prefer it to #625 since it does rely on an official action

@masterleinad
Copy link
Contributor

If this one works I prefer it to #625 since it does rely on an official action

I'm happy if we just merge and see what happens. I have more confidence in #623, though.

@JBludau
Copy link
Contributor

JBludau commented Feb 4, 2025

If this one works I prefer it to #625 since it does rely on an official action

I'm happy if we just merge and see what happens. I have more confidence in #623, though.

debugging actions is just a pain

@dalg24
Copy link
Member Author

dalg24 commented Feb 4, 2025

Is this ready? Did you test it locally? Please share a link.

@masterleinad
Copy link
Contributor

Is this ready? Did you test it locally? Please share a link.

As I said before I had trouble testing it but we could just give it a shot. I have more confidence in the other pull request.

@dalg24
Copy link
Member Author

dalg24 commented Feb 4, 2025

I can't approve it as I originated the PR

@dalg24 dalg24 merged commit fa6ddd1 into kokkos:main Feb 4, 2025
3 checks passed
@masterleinad
Copy link
Contributor

masterleinad commented Feb 5, 2025

Error: Creating Pages deployment failed
Error: HttpError: Invalid deployment branch and no branch protection rules set in the environment. Deployments are only allowed from deploy-doc-site

https://github.com/orgs/community/discussions/39054 suggests to fix it in the settings.

@dalg24
Copy link
Member Author

dalg24 commented Feb 5, 2025

Fixed
Apparently the link you shared had the solution I got to buried in it https://github.com/orgs/community/discussions/39054#discussioncomment-8553887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants