-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update action to deploy to GitHub pages #623
Conversation
This is an attempt to fix the permissions error on the last merge. The code is inspired from https://github.com/actions/upload-pages-artifact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build stage seems to be working. Did you check the deploy stage?
This reverts commit 93756e1.
This is an attempt to fix the permissions error on the last merge. The code is inspired from https://github.com/actions/upload-pages-artifact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a drive by typo
If this one works I prefer it to #625 since it does rely on an official action |
Is this ready? Did you test it locally? Please share a link. |
As I said before I had trouble testing it but we could just give it a shot. I have more confidence in the other pull request. |
I can't approve it as I originated the PR |
https://github.com/orgs/community/discussions/39054 suggests to fix it in the settings. |
Fixed |
This is an attempt to fix the permissions error on the last merge. The code is inspired from https://github.com/actions/upload-pages-artifact