Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added startedOn and lastReviewedOn #838

Merged

Conversation

jeevansegu
Copy link
Contributor

This PR resolves issue #836.
This pull request adds two new fields to the ambassador schema to enable tracking the date an ambassador started and the last time their status was reviewed. This will ensure compliance with the requirement to review ambassador statuses annually.

  1. Schema Updates:

    • Added startedOn (Date): Tracks the date an individual became an ambassador.
    • Added lastReviewedOn (Date): Tracks the date the ambassador status was last reviewed.
  2. Data Population:

    • Populated startedOn for existing ambassadors based on available historical data.

Data Updates

  • Retrieved start dates from existing records, verified by historical Slack messages (populated using the month and year when the ambassador was added to the channel).
  • Populated the startedOn field for all current ambassadors.

Code Changes

  • Updated the ambassador model to include the new fields.
  • Made startedOn date a required field.

Verification

  • Start dates were confirmed via Slack server history.

Checklist

  • Schema updated with startedOn and lastReviewedOn fields.
  • Existing data populated with verified startedOn dates.
  • All changes included in a single PR.
  • Tested and verified changes.

@Relequestual : Please review the proposed schema changes and confirm that the populated data aligns with expectations. Any feedback or further suggestions are welcome!

@jeevansegu jeevansegu marked this pull request as ready for review December 13, 2024 11:20
Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thank you for your contribution.

Thank you for the good write up also!

If you want to continue to contribute to the JSON Schema project, I invite you to join our slack server. You can find the link on our website =]

@Relequestual Relequestual merged commit 8ddbfeb into json-schema-org:main Dec 13, 2024
2 checks passed
@jeevansegu jeevansegu deleted the segu-date-in-ambassadors-data branch December 13, 2024 11:45
@jeevansegu
Copy link
Contributor Author

Nice work. Thank you for your contribution.

Thank you for the good write up also!

If you want to continue to contribute to the JSON Schema project, I invite you to join our slack server. You can find the link on our website =]

Thank you =] i will join the server

@Relequestual Relequestual mentioned this pull request Dec 13, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants