Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date to ambassadors data #836

Closed
2 tasks done
Relequestual opened this issue Dec 12, 2024 · 6 comments
Closed
2 tasks done

Add date to ambassadors data #836

Relequestual opened this issue Dec 12, 2024 · 6 comments
Assignees
Labels
good first issue Good for newcomers Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue.

Comments

@Relequestual
Copy link
Member

Relequestual commented Dec 12, 2024

Summary: Ambassador status should be reviewed every year, so we need to log the date of issue.

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy) No

It is adding data based on what was already defined for the program.

Details:

Required to resolve

We have a small number of ambassadors. They were added in one or two groups on a specific date, I forget which. @benjagm can bring clarity on the date, or it might be in the slack server history.

  • Add startedOn and lastReviewedOn fields to the schema
  • Add the data for startedOn dates.

I believe this is the best approach as it would be nice to also track how many years they have been an ambassador vs just when they are next up for review.

Any further requirements to resolve this issue
Confirm dates are correct with evidence.
The above should be all one PR.

@Relequestual Relequestual added good first issue Good for newcomers Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Available No one has claimed responsibility for resolving this issue. labels Dec 12, 2024
@jeevansegu
Copy link
Contributor

jeevansegu commented Dec 12, 2024

@Relequestual
I would like to work on this, Please assign this issue to me.
i was considering if i could add these two fields(startedOn and lastReviewedOn) at the end of the schema after contributions
if that is okay, i would like to ask @benjagm for the dates to add for startedOn and lastReviewedOn
also is the dates in the format of date, month and year or just month and year

@MohdAbdulSami
Copy link

hi @Relequestual I would also love to work on this issue, but I want to understand how can i go ahead with solving the issue as its going to be my first time solving

@Relequestual
Copy link
Member Author

@Relequestual I would like to work on this, Please assign this issue to me. i was considering if i could add these two fields(startedOn and lastReviewedOn) at the end of the schema after contributions if that is okay - @jeevansegu

Sure, go ahead with making a PR!

i would like to ask @benjagm for the dates to add for startedOn and lastReviewedOn also is the dates in the format of date, month and year or just month and year

You should be able to work this out based on the git history on GitHub. If you're still unsure after that, do as Benja.

Month and year is fine, following what we have already used.

Thanks! =]

@jeevansegu
Copy link
Contributor

@Relequestual I would like to work on this, Please assign this issue to me. i was considering if i could add these two fields(startedOn and lastReviewedOn) at the end of the schema after contributions if that is okay - @jeevansegu

Sure, go ahead with making a PR!

i would like to ask @benjagm for the dates to add for startedOn and lastReviewedOn also is the dates in the format of date, month and year or just month and year

You should be able to work this out based on the git history on GitHub. If you're still unsure after that, do as Benja.

Month and year is fine, following what we have already used.

Thanks! =]

I'll look into the git history and reach out to Benja if I have any doubts
Thank you

@Relequestual
Copy link
Member Author

hi @Relequestual I would also love to work on this issue, but I want to understand how can i go ahead with solving the issue as its going to be my first time solving - @MohdAbdulSami

Thanks for your interest. If you're looking to break into open source, you may find other good first issues issues here: https://goodfirstissue.dev/

@Relequestual
Copy link
Member Author

Fixed with #838

@Relequestual Relequestual added Status: Completed Nothing further to be done with this issue. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue.
Projects
None yet
Development

No branches or pull requests

3 participants