Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dns/jenkins.io) merge records to ensure SPF is valid #338

Merged

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jan 22, 2025

@dduportal
Copy link
Contributor Author

LGTM:

# azurerm_dns_txt_record.apex_jenkinsio will be updated in-place
  ~ resource "azurerm_dns_txt_record" "apex_jenkinsio" {
        id                  = "/subscriptions/dff2ec18-6a8e-405c-8e45-b7df7465acf0/resourceGroups/proddns_jenkinsio/providers/Microsoft.Network/dnsZones/jenkins.io/TXT/@"
        name                = "@"
        tags                = {
            "repository" = "jenkins-infra/azure-net"
            "scope"      = "terraform-managed"
        }
        # (4 unchanged attributes hidden)

      - record {
          - value = "v=spf1 include:mailgun.org ~all" -> null
        }
      - record {
          - value = "v=spf1 include:sendgrid.net -all" -> null
        }
      + record {
          + value = "v=spf1 include:mailgun.org include:sendgrid.net -all"
        }

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@dduportal dduportal merged commit 7deaa08 into jenkins-infra:main Jan 22, 2025
3 checks passed
@dduportal dduportal deleted the fix/dns/jenkins.io/merge-spf branch January 22, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant