-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Godot debug symbols guide #12843
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 648 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
|
||
<Alert> | ||
|
||
Learn more about debug formats in [Debug Information Files](/platforms/native/data-management/debug-files/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking to Native page, as it's more likely to stay up-to-date on this topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is what we should be doing, but I do agree it's annoying things can get out of sync since we're duplicating all docs now. @coolguyzone thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps for that general debug file info we shoujld add to an include and reuse it everywhere.
That's the same in all docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still unclear to me what is the consensus on this.
|
||
<Alert> | ||
|
||
Learn more about debug formats in [Debug Information Files](/platforms/native/data-management/debug-files/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is what we should be doing, but I do agree it's annoying things can get out of sync since we're duplicating all docs now. @coolguyzone thoughts?
|
||
<Alert> | ||
|
||
Learn more about debug formats in [Debug Information Files](/platforms/native/data-management/debug-files/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps for that general debug file info we shoujld add to an include and reuse it everywhere.
That's the same in all docs
@andreiborza if by any chance you're looking for readable stack traces and you'd wanna try this out and give feedback (or a review) that'll be much appreciated |
Co-authored-by: Bruno Garcia <[email protected]>
605d55f
to
66780ce
Compare
Co-authored-by: Andrei <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
This is looking great. A few things we can follow up on but lets get that shipped to start! |
DESCRIBE YOUR PR
Add a guide on how to get readable stack traces with SDK for Godot Engine.
I've tested these instructions on Windows and Arch Linux, successfully getting traces symbolicated for crashes.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES