Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests that require access to the token #1063

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

tuliom
Copy link
Collaborator

@tuliom tuliom commented Feb 4, 2025

Add function to GithubClient.has_token() and use it in order to skip tests that require access to a Github token.
This will allow to run a smaller set of tests from other forks and, most importantly, won't block their merge.

@tuliom tuliom force-pushed the skip-tests-token branch 6 times, most recently from 0e77fea to 0af3ff7 Compare February 4, 2025 14:32
Raise an exception when the Github token is not available and use it in
order to skip tests that require access to this token.
This will allow to run a smaller set of tests from other forks and, most
importantly, won't block their merge.
@tuliom
Copy link
Collaborator Author

tuliom commented Feb 4, 2025

This PR is finally ready to be reviewed.

@nikic nikic requested a review from kwk February 4, 2025 15:55
Copy link
Collaborator

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but @kwk will probably want to take a look.

Copy link
Collaborator

@kwk kwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwk kwk merged commit 5c76c77 into fedora-llvm-team:main Feb 5, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants