Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set myself as the current maintainer #1061

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

tuliom
Copy link
Collaborator

@tuliom tuliom commented Feb 3, 2025

No description provided.

@tuliom
Copy link
Collaborator Author

tuliom commented Feb 4, 2025

There appears to be an infrastructure error with the execution of the python code format test that is blocking the merge of this PR.

@nikic
Copy link
Collaborator

nikic commented Feb 4, 2025

@kwk Can you please disable the required checks on this repo? The python tests don't work for PRs from forks.

@tuliom
Copy link
Collaborator Author

tuliom commented Feb 4, 2025

I've just created #1063 hoping to skip this issue.

@kwk
Copy link
Collaborator

kwk commented Feb 5, 2025

@kwk Can you please disable the required checks on this repo? The python tests don't work for PRs from forks.

It basically has to do with how protective github was with our secrets:

They are not passed to workflows that are triggered by a pull request from a fork.

That said, please create branches for your PRs to the aforementioned repo in the main repo and not in your fork. For outside collaborators this isn't possible but for 99% of the work done in that repository it should be. You should all be able to push branches to the main repo, if not, please contact me.

I think we might get away without using secrets for our test runs if we used python's mock facility. I've documented a few examples in this repository because I wasn't sure I can get them to work in our repository. With these documented examples I think it is possible to mock github, copr and tmt with some effort. Then we wouldn't need any secrets and you could create PRs from your fork and run tests even locally.

But for now please create branches in the main repo.

@kwk kwk merged commit 6e3c916 into fedora-llvm-team:main Feb 5, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants