-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qm.container: add tmpfs additional flags #727
Conversation
Reviewer's Guide by SourceryThis pull request adds support for additional flags when mounting a tmpfs volume in a container. This allows users to customize the tmpfs mount options beyond the default settings. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dougsland - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you add a brief explanation of the new flags and how they might be used?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
abad583
to
448a1d0
Compare
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove that lines from ostree testing
QM_TMP_DIR="/var/tmp.dir"
We will have a clue that this fix is working,
https://github.com/containers/qm/blob/main/tests/ffi/common/prepare.sh#L75-L79
BTW all that make
subsystems/img_tempdir could be deleted.
and also deleted from READMEs
Resolves: #723 Signed-off-by: Douglas Schilling Landgraf <[email protected]>
448a1d0
to
223c26b
Compare
Resolves: #723
Summary by Sourcery
New Features: