-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve the name of var partition #740
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request improves the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pengshanyu - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using more descriptive variable names than
var_partition_name
to improve readability. - The
lsblk
anddf -kh
commands are helpful for debugging, but should be removed before merging.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
I'm not sure why there are failures of |
Please refer that, I assume it will be online soon |
Signed-off-by: pengshanyu <[email protected]> improve oom.conf;improve variable names improve PodmanArgs
@pengshanyu So if this solves #722 |
Resolve: #722
Summary by Sourcery
Tests: