Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languagesDirective: Adapt the /list/bears API change #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

languagesDirective: Adapt the /list/bears API change #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions resources/js/Directives/languagesDirective.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ app.directive('languages', ['$http', '$timeout' ,function ($http, $timeout) {
$scope.lang_loader=true;
$http.get(api_link + '/list/bears')
.then(function(data){
arr = []
angular.forEach(Object.keys(data["data"]), function(value, key){
arr = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ';' is unrelated to the changes. #177 (comment) was about that is not part of this problem.
@gkrishnan724, if you want changes to existing code, please create a new issue.

angular.forEach(data["data"], function(bear){
arr.push({
"name" : value,
"desc" : data["data"][value]["desc"],
"languages": data["data"][value]["languages"]
})
"name" : bear["name"],
"desc" : bear["desc"],
"languages": bear["languages"]
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

})
$scope.bearList = arr
$scope.bearList = arr;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

$scope.$evalAsync();
$scope.lang_loader = false;
$scope.$storage.bear_data = arr
Expand Down