languagesDirective: Adapt the /list/bears API change #177
Conversation
meetmangukiya
force-pushed
the
meet/api-change
branch
from
55f16ff to
2fc01e8
Compare
|
ack 2fc01e8 |
|
xref: https://gitlab.com/coala/landing/merge_requests/39 is the change |
| @@ -21,11 +21,11 @@ app.directive('languages', ['$http', '$timeout' ,function ($http, $timeout) { | |||
| $http.get(api_link + '/list/bears') | |||
| .then(function(data){ | |||
| arr = [] | |||
There was a problem hiding this comment.
being a semi-colon nazi :P
| "languages": data["data"][value]["languages"] | ||
| "name" : bear["name"], | ||
| "desc" : bear["desc"], | ||
| "languages": bear["languages"] | ||
| }) |
| "languages": data["data"][value]["languages"] | ||
| "name" : bear["name"], | ||
| "desc" : bear["desc"], | ||
| "languages": bear["languages"] | ||
| }) | ||
| }) | ||
| $scope.bearList = arr |
|
Hey! This wasn't updated since a while. Please check up on it! |
meetmangukiya
force-pushed
the
meet/api-change
branch
from
2fc01e8 to
92e45bc
Compare
|
status/blocked until https://gitlab.com/coala/landing/merge_requests/39 is merged |
| @@ -20,15 +20,15 @@ app.directive('languages', ['$http', '$timeout' ,function ($http, $timeout) { | |||
| $scope.lang_loader=true; | |||
| $http.get(api_link + '/list/bears') | |||
| .then(function(data){ | |||
| arr = [] | |||
| angular.forEach(Object.keys(data["data"]), function(value, key){ | |||
| arr = []; | |||
There was a problem hiding this comment.
This ';' is unrelated to the changes. #177 (comment) was about that is not part of this problem.
@gkrishnan724, if you want changes to existing code, please create a new issue.
| }) | ||
| $scope.bearList = arr | ||
| $scope.bearList = arr; |
| "name" : bear["name"], | ||
| "desc" : bear["desc"], | ||
| "languages": bear["languages"] | ||
| }); |
|
Hey! This wasn't updated since a while. Please check up on it! |
5 similar comments
|
Hey! This wasn't updated since a while. Please check up on it! |
|
Hey! This wasn't updated since a while. Please check up on it! |
|
Hey! This wasn't updated since a while. Please check up on it! |
|
Hey! This wasn't updated since a while. Please check up on it! |
|
Hey! This wasn't updated since a while. Please check up on it! |
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!