-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28703: Integral Data Type Overflow Not Enforced for JsonSerDe and UDFs #5608
Open
armitage420
wants to merge
2
commits into
apache:master
Choose a base branch
from
armitage420:HIVE-28703
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"tiny_value": 128, "small_value" : 32768, "int_value" : 2147483648, "big_value" : 9223372036854775808} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -146,6 +146,10 @@ public IntWritable evaluate(LongWritable i) { | |
if (i == null) { | ||
return null; | ||
} else { | ||
long value = i.get(); | ||
if (value < Integer.MIN_VALUE || value > Integer.MAX_VALUE) { | ||
throw new IllegalArgumentException("Value out of range for Integer: " + value); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, generic exception. |
||
} | ||
intWritable.set((int) i.get()); | ||
return intWritable; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,6 +128,10 @@ public ShortWritable evaluate(IntWritable i) { | |
if (i == null) { | ||
return null; | ||
} else { | ||
int value = i.get(); | ||
if (value < Short.MIN_VALUE || value > Short.MAX_VALUE) { | ||
throw new IllegalArgumentException("Value out of range for Short: " + value); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same, can you please use Hive specific exceptions |
||
} | ||
shortWritable.set((short) i.get()); | ||
return shortWritable; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
drop table if exists json_serde1_1; | ||
|
||
create table json_serde1_1 (tiny_value TINYINT, small_value SMALLINT, int_value INT, big_value BIGINT) | ||
row format serde 'org.apache.hadoop.hive.serde2.JsonSerDe'; | ||
|
||
insert into table json_serde1_1 values (128, 32768, 2147483648, 9223372036854775808); | ||
|
||
select * from json_serde1_1; | ||
|
||
drop table json_serde1_1; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
drop table if exists json_serde2_1; | ||
|
||
create table json_serde2_1 (tiny_value TINYINT, small_value SMALLINT, int_value INT, big_value BIGINT) | ||
row format serde 'org.apache.hadoop.hive.serde2.JsonSerDe'; | ||
|
||
LOAD DATA LOCAL INPATH '../../data/files/sampleJson.json' INTO TABLE json_serde2_1; | ||
|
||
select * from json_serde2_1; | ||
|
||
drop table json_serde2_1; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
drop table if exists json_serde3_1; | ||
|
||
create table json_serde3_1 (tiny_value TINYINT, small_value SMALLINT, int_value INT, big_value BIGINT) | ||
row format serde 'org.apache.hive.hcatalog.data.JsonSerDe'; | ||
|
||
insert into table json_serde3_1 values (127, 32768, 2147483648, 9223372036854775808); | ||
|
||
select * from json_serde3_1; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
drop table if exists json_serde4_1; | ||
|
||
create table json_serde4_1 (tiny_value TINYINT, small_value SMALLINT, int_value INT, big_value BIGINT) | ||
row format serde 'org.apache.hive.hcatalog.data.JsonSerDe'; | ||
|
||
LOAD DATA LOCAL INPATH '../../data/files/sampleJson.json' INTO TABLE json_serde4_1; | ||
|
||
select * from json_serde4_1; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
PREHOOK: query: drop table if exists json_serde1_1 | ||
PREHOOK: type: DROPTABLE | ||
PREHOOK: Output: database:default | ||
POSTHOOK: query: drop table if exists json_serde1_1 | ||
POSTHOOK: type: DROPTABLE | ||
POSTHOOK: Output: database:default | ||
PREHOOK: query: create table json_serde1_1 (tiny_value TINYINT, small_value SMALLINT, int_value INT, big_value BIGINT) | ||
row format serde 'org.apache.hadoop.hive.serde2.JsonSerDe' | ||
PREHOOK: type: CREATETABLE | ||
PREHOOK: Output: database:default | ||
PREHOOK: Output: default@json_serde1_1 | ||
POSTHOOK: query: create table json_serde1_1 (tiny_value TINYINT, small_value SMALLINT, int_value INT, big_value BIGINT) | ||
row format serde 'org.apache.hadoop.hive.serde2.JsonSerDe' | ||
POSTHOOK: type: CREATETABLE | ||
POSTHOOK: Output: database:default | ||
POSTHOOK: Output: default@json_serde1_1 | ||
PREHOOK: query: insert into table json_serde1_1 values (128, 32768, 2147483648, 9223372036854775808) | ||
PREHOOK: type: QUERY | ||
PREHOOK: Input: _dummy_database@_dummy_table | ||
PREHOOK: Output: default@json_serde1_1 | ||
Status: Failed | ||
Vertex failed, vertexName=Map 1, vertexId=vertex_#ID#, diagnostics=[Task failed, taskId=task_#ID#, diagnostics=[TaskAttempt 0 failed, info=[Error: Error while running task ( failure ) : attempt_#ID#:java.lang.RuntimeException: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Unable to execute method public org.apache.hadoop.hive.serde2.io.ByteWritable org.apache.hadoop.hive.ql.udf.UDFToByte.evaluate(org.apache.hadoop.io.IntWritable):Value out of range for Byte: 128 | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.reflect.InvocationTargetException | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.IllegalArgumentException: Value out of range for Byte: 128 | ||
#### A masked pattern was here #### | ||
], TaskAttempt 1 failed, info=[Error: Error while running task ( failure ) : attempt_#ID#:java.lang.RuntimeException: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Unable to execute method public org.apache.hadoop.hive.serde2.io.ByteWritable org.apache.hadoop.hive.ql.udf.UDFToByte.evaluate(org.apache.hadoop.io.IntWritable):Value out of range for Byte: 128 | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.reflect.InvocationTargetException | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.IllegalArgumentException: Value out of range for Byte: 128 | ||
#### A masked pattern was here #### | ||
]], Vertex did not succeed due to OWN_TASK_FAILURE, failedTasks:1 killedTasks:0, Vertex vertex_#ID# [Map 1] killed/failed due to:OWN_TASK_FAILURE] | ||
[Masked Vertex killed due to OTHER_VERTEX_FAILURE] | ||
DAG did not succeed due to VERTEX_FAILURE. failedVertices:1 killedVertices:1 | ||
FAILED: Execution Error, return code 2 from org.apache.hadoop.hive.ql.exec.tez.TezTask. Vertex failed, vertexName=Map 1, vertexId=vertex_#ID#, diagnostics=[Task failed, taskId=task_#ID#, diagnostics=[TaskAttempt 0 failed, info=[Error: Error while running task ( failure ) : attempt_#ID#:java.lang.RuntimeException: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Unable to execute method public org.apache.hadoop.hive.serde2.io.ByteWritable org.apache.hadoop.hive.ql.udf.UDFToByte.evaluate(org.apache.hadoop.io.IntWritable):Value out of range for Byte: 128 | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.reflect.InvocationTargetException | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.IllegalArgumentException: Value out of range for Byte: 128 | ||
#### A masked pattern was here #### | ||
], TaskAttempt 1 failed, info=[Error: Error while running task ( failure ) : attempt_#ID#:java.lang.RuntimeException: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Unable to execute method public org.apache.hadoop.hive.serde2.io.ByteWritable org.apache.hadoop.hive.ql.udf.UDFToByte.evaluate(org.apache.hadoop.io.IntWritable):Value out of range for Byte: 128 | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.reflect.InvocationTargetException | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.IllegalArgumentException: Value out of range for Byte: 128 | ||
#### A masked pattern was here #### | ||
]], Vertex did not succeed due to OWN_TASK_FAILURE, failedTasks:1 killedTasks:0, Vertex vertex_#ID# [Map 1] killed/failed due to:OWN_TASK_FAILURE][Masked Vertex killed due to OTHER_VERTEX_FAILURE]DAG did not succeed due to VERTEX_FAILURE. failedVertices:1 killedVertices:1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
PREHOOK: query: drop table if exists json_serde2_1 | ||
PREHOOK: type: DROPTABLE | ||
PREHOOK: Output: database:default | ||
POSTHOOK: query: drop table if exists json_serde2_1 | ||
POSTHOOK: type: DROPTABLE | ||
POSTHOOK: Output: database:default | ||
PREHOOK: query: create table json_serde2_1 (tiny_value TINYINT, small_value SMALLINT, int_value INT, big_value BIGINT) | ||
row format serde 'org.apache.hadoop.hive.serde2.JsonSerDe' | ||
PREHOOK: type: CREATETABLE | ||
PREHOOK: Output: database:default | ||
PREHOOK: Output: default@json_serde2_1 | ||
POSTHOOK: query: create table json_serde2_1 (tiny_value TINYINT, small_value SMALLINT, int_value INT, big_value BIGINT) | ||
row format serde 'org.apache.hadoop.hive.serde2.JsonSerDe' | ||
POSTHOOK: type: CREATETABLE | ||
POSTHOOK: Output: database:default | ||
POSTHOOK: Output: default@json_serde2_1 | ||
PREHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/sampleJson.json' INTO TABLE json_serde2_1 | ||
PREHOOK: type: LOAD | ||
#### A masked pattern was here #### | ||
PREHOOK: Output: default@json_serde2_1 | ||
POSTHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/sampleJson.json' INTO TABLE json_serde2_1 | ||
POSTHOOK: type: LOAD | ||
#### A masked pattern was here #### | ||
POSTHOOK: Output: default@json_serde2_1 | ||
PREHOOK: query: select * from json_serde2_1 | ||
PREHOOK: type: QUERY | ||
PREHOOK: Input: default@json_serde2_1 | ||
#### A masked pattern was here #### | ||
POSTHOOK: query: select * from json_serde2_1 | ||
POSTHOOK: type: QUERY | ||
POSTHOOK: Input: default@json_serde2_1 | ||
#### A masked pattern was here #### | ||
Failed with exception java.io.IOException:org.apache.hadoop.hive.serde2.SerDeException: java.lang.IllegalArgumentException: Failed to parse integral value for category BYTE: 128 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
PREHOOK: query: drop table if exists json_serde3_1 | ||
PREHOOK: type: DROPTABLE | ||
PREHOOK: Output: database:default | ||
POSTHOOK: query: drop table if exists json_serde3_1 | ||
POSTHOOK: type: DROPTABLE | ||
POSTHOOK: Output: database:default | ||
PREHOOK: query: create table json_serde3_1 (tiny_value TINYINT, small_value SMALLINT, int_value INT, big_value BIGINT) | ||
row format serde 'org.apache.hive.hcatalog.data.JsonSerDe' | ||
PREHOOK: type: CREATETABLE | ||
PREHOOK: Output: database:default | ||
PREHOOK: Output: default@json_serde3_1 | ||
POSTHOOK: query: create table json_serde3_1 (tiny_value TINYINT, small_value SMALLINT, int_value INT, big_value BIGINT) | ||
row format serde 'org.apache.hive.hcatalog.data.JsonSerDe' | ||
POSTHOOK: type: CREATETABLE | ||
POSTHOOK: Output: database:default | ||
POSTHOOK: Output: default@json_serde3_1 | ||
PREHOOK: query: insert into table json_serde3_1 values (127, 32768, 2147483648, 9223372036854775808) | ||
PREHOOK: type: QUERY | ||
PREHOOK: Input: _dummy_database@_dummy_table | ||
PREHOOK: Output: default@json_serde3_1 | ||
Status: Failed | ||
Vertex failed, vertexName=Map 1, vertexId=vertex_#ID#, diagnostics=[Task failed, taskId=task_#ID#, diagnostics=[TaskAttempt 0 failed, info=[Error: Error while running task ( failure ) : attempt_#ID#:java.lang.RuntimeException: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Unable to execute method public org.apache.hadoop.hive.serde2.io.ShortWritable org.apache.hadoop.hive.ql.udf.UDFToShort.evaluate(org.apache.hadoop.io.IntWritable):Value out of range for Short: 32768 | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.reflect.InvocationTargetException | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.IllegalArgumentException: Value out of range for Short: 32768 | ||
#### A masked pattern was here #### | ||
], TaskAttempt 1 failed, info=[Error: Error while running task ( failure ) : attempt_#ID#:java.lang.RuntimeException: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Unable to execute method public org.apache.hadoop.hive.serde2.io.ShortWritable org.apache.hadoop.hive.ql.udf.UDFToShort.evaluate(org.apache.hadoop.io.IntWritable):Value out of range for Short: 32768 | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.reflect.InvocationTargetException | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.IllegalArgumentException: Value out of range for Short: 32768 | ||
#### A masked pattern was here #### | ||
]], Vertex did not succeed due to OWN_TASK_FAILURE, failedTasks:1 killedTasks:0, Vertex vertex_#ID# [Map 1] killed/failed due to:OWN_TASK_FAILURE] | ||
[Masked Vertex killed due to OTHER_VERTEX_FAILURE] | ||
DAG did not succeed due to VERTEX_FAILURE. failedVertices:1 killedVertices:1 | ||
FAILED: Execution Error, return code 2 from org.apache.hadoop.hive.ql.exec.tez.TezTask. Vertex failed, vertexName=Map 1, vertexId=vertex_#ID#, diagnostics=[Task failed, taskId=task_#ID#, diagnostics=[TaskAttempt 0 failed, info=[Error: Error while running task ( failure ) : attempt_#ID#:java.lang.RuntimeException: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Unable to execute method public org.apache.hadoop.hive.serde2.io.ShortWritable org.apache.hadoop.hive.ql.udf.UDFToShort.evaluate(org.apache.hadoop.io.IntWritable):Value out of range for Short: 32768 | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.reflect.InvocationTargetException | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.IllegalArgumentException: Value out of range for Short: 32768 | ||
#### A masked pattern was here #### | ||
], TaskAttempt 1 failed, info=[Error: Error while running task ( failure ) : attempt_#ID#:java.lang.RuntimeException: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing writable | ||
#### A masked pattern was here #### | ||
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Unable to execute method public org.apache.hadoop.hive.serde2.io.ShortWritable org.apache.hadoop.hive.ql.udf.UDFToShort.evaluate(org.apache.hadoop.io.IntWritable):Value out of range for Short: 32768 | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.reflect.InvocationTargetException | ||
#### A masked pattern was here #### | ||
Caused by: java.lang.IllegalArgumentException: Value out of range for Short: 32768 | ||
#### A masked pattern was here #### | ||
]], Vertex did not succeed due to OWN_TASK_FAILURE, failedTasks:1 killedTasks:0, Vertex vertex_#ID# [Map 1] killed/failed due to:OWN_TASK_FAILURE][Masked Vertex killed due to OTHER_VERTEX_FAILURE]DAG did not succeed due to VERTEX_FAILURE. failedVertices:1 killedVertices:1 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to use Hive-specific exceptions. Hive has an exception
UDFArgumentException
which seems suitable here.