HIVE-28703: Integral Data Type Overflow Not Enforced for JsonSerDe and UDFs #5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armitage420
changed the title
armitage420
force-pushed
the
HIVE-28703
branch
from
2d971c5 to
3d680a4
Compare
armitage420
changed the title
|
difin
reviewed
Jan 20, 2025
| @@ -128,6 +128,11 @@ public ByteWritable evaluate(IntWritable i) { | |||
| if (i == null) { | |||
| return null; | |||
| } else { | |||
| int value = i.get(); | |||
| if (value < Byte.MIN_VALUE || value > Byte.MAX_VALUE) { | |||
| throw new IllegalArgumentException("Value out of range for Byte: " + value); | |||
There was a problem hiding this comment.
It is better to use Hive-specific exceptions. Hive has an exception UDFArgumentException which seems suitable here.
difin
reviewed
Jan 20, 2025
| @@ -146,6 +146,10 @@ public IntWritable evaluate(LongWritable i) { | |||
| if (i == null) { | |||
| return null; | |||
| } else { | |||
| long value = i.get(); | |||
| if (value < Integer.MIN_VALUE || value > Integer.MAX_VALUE) { | |||
| throw new IllegalArgumentException("Value out of range for Integer: " + value); | |||
There was a problem hiding this comment.
Same here, generic exception.
difin
reviewed
Jan 20, 2025
| @@ -128,6 +128,10 @@ public ShortWritable evaluate(IntWritable i) { | |||
| if (i == null) { | |||
| return null; | |||
| } else { | |||
| int value = i.get(); | |||
| if (value < Short.MIN_VALUE || value > Short.MAX_VALUE) { | |||
| throw new IllegalArgumentException("Value out of range for Short: " + value); | |||
There was a problem hiding this comment.
same, can you please use Hive specific exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pull request addresses the issue of data type overflow not being enforced when using JsonSerDe in Apache Hive. The proposed changes aim to ensure strict data type validation during the insertion and loading of data into tables defined with types like TINYINT, SMALLINT, INT, and BIGINT.
Why are the changes needed?
This behavior can lead to data integrity issues and unexpected results.
Does this PR introduce any user-facing change?
Yes
Is the change a dependency upgrade?
No
How was this patch tested?
Tests introduced in this PR and local machine