wwshell fixes #236
Merged
wwshell fixes #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #223 was merged the actions did not pass. This PR is trying to fix the issues that caused it to fail.
The port argument was missing in some of the function calls. I must have been using a version with the default port hardcoded back when I worked on this before.
The other pylint error was for duplicate lines between wwshell.main and circup.main. I looked for ways to refactor the initial section but didn't come to any implementation that wasn't more complex. The fact that this chunk sets a few local variables coupled with the fact that circup actually has an else block for when not using_webworkflow make it tricky to try to refactor this into a shared function.
Also removed a handful of print statements.