Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wwshell file management CLI #223

Merged
merged 7 commits into from
Jan 2, 2025
Merged

wwshell file management CLI #223

merged 7 commits into from
Jan 2, 2025

Conversation

FoamyGuy
Copy link
Contributor

This is a start on the idea discussed here: adafruit/circuitpython#9121

It's currently setup as a separate command, but gets alongside circup when installed via pip.

I added a basic help doc for the new tool, but there is perhaps still room for improvement. Maybe a link in the main readme to the wwshell one would be good?

@FoamyGuy FoamyGuy marked this pull request as draft June 11, 2024 16:10
@FoamyGuy FoamyGuy marked this pull request as ready for review June 17, 2024 16:54
@FoamyGuy
Copy link
Contributor Author

I've merged main to this branch and resolved the conflicts in the new pyproject.toml config file.

@dhalbert
Copy link
Contributor

@FoamyGuy Is this still fine? Any reason not to merge it?

@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Jan 2, 2025

@dhalbert I do not know of any reason not to merge. As far as I know this should be good, but it has been a while since I messed with it. I am doing some tinkering on a device without USB storage though so it would be convenient to have this utility.

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dhalbert dhalbert merged commit a03d504 into adafruit:main Jan 2, 2025
1 check passed
@dhalbert
Copy link
Contributor

dhalbert commented Jan 2, 2025

@FoamyGuy I merged this but the merge test failed ☹️

@FoamyGuy FoamyGuy mentioned this pull request Jan 3, 2025
@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Jan 3, 2025

@dhalbert I've created #236 to address the failed actions runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants