FIX: Replace the AM/PM toggle ButtonGroup with ToggleGroupControl. #61562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @gutenbergplugin. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @patil-vipul! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
github-actions
bot
added
the
First-time Contributor
juanfra
added
[Type] Enhancement
mirka
reviewed
May 22, 2024
Comment on lines
285
to
287
| * This is not ideal, but best of we can do for now until we refactor | ||
| * AM/PM into accessible elements, like radio buttons. | ||
| */ |
There was a problem hiding this comment.
I believe we can remove this comment now?
Co-authored-by: afercia <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: jameskoster <[email protected]>
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ellatrix <[email protected]>
…#62137) Co-authored-by: richtabor <[email protected]> Co-authored-by: jasmussen <[email protected]>
…esence (WordPress#62132) * Refactor image block control rendering logic for clarity. * Refactor conditional rendering logic for block controls. Co-authored-by: amitraj2203 <[email protected]> Co-authored-by: michalczaplinski <[email protected]> Co-authored-by: annezazu <[email protected]>
* "Edit" instead of color count * remove unused style * use chevron * Update style-variations.spec.js * lint Co-authored-by: richtabor <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: annezazu <[email protected]>
…r package (WordPress#61879) Co-authored-by: jorgefilipecosta <[email protected]>
…uled) (WordPress#62070) Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: annezazu <[email protected]>
Add a `scriptmoduledata_{ MODULE_ID }` filter that allows data to be
embedded in page HTML for use by Script Modules.
For example:
add_filter(
'scriptmoduledata_MyScriptModuleID',
function ( array $data ): array {
$data['doesIt'] = 'it works';
return $data;
}
);
See the proposal for details:
https://make.wordpress.org/core/2024/05/06/proposal-server-to-client-data-sharing-for-script-modules/
…#62103) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]>
) Co-authored-by: tyxla <[email protected]> Co-authored-by: Mamaduka <[email protected]>
…rdPress#62088) If a block variation's `isActive` property is a `string[]`, support "object paths" (i.e. dot ["property accessors"](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Property_accessors)), such as ```js isActive: [ 'namespace', 'query.postType' ] ``` --------- Co-authored-by: ntsekouras <[email protected]>
…dPress#62076) * Implemented: Update alt text decision tree links to be translatable * Implemented: Update alt text decision tree links to be translatable * Implemented Suggestions * Implemented comment related changes Co-authored-by: narenin <[email protected]> Co-authored-by: joedolson <[email protected]> Co-authored-by: michalczaplinski <[email protected]> Co-authored-by: t-hamano <[email protected]>
…rdPress#62074) * hide the presets panel for when there are less or exactly one presets available * tweak logic to return null if there is only one variation (the default). --------- Co-authored-by: draganescu <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: bgardner <[email protected]> Co-authored-by: hbhalodia <[email protected]>
…agraph block (WordPress#62069) * Mobile - Prevent deleting content when backspacing in the first Paragraph block at start * Update Changelog Co-authored-by: geriux <[email protected]> Co-authored-by: twstokes <[email protected]>
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: jeryj <[email protected]>
* Add PostDiscussionPanel editor component JSDocs * Auto-generate editor docs or PostDiscussionPanel component * Refine PostDiscussionPanel editor component JSDocs * Auto-generate editor docs for PostDiscussionPanel updates
* Add PostExcerptPanel editor component JSDocs * Auto-generate editor docs for PostExcerptPanel component * Refine PostExcerptPanel editor component JSDocs * Auto-generate editor docs for PostExcerptPanel updates
…onents (WordPress#61970) * Add PostPendingStatus editor component JSDocs * Add PostPendingStatusCheck editor component JSDocs * Auto-generate editor docs for PostPendingStatus additions * Refine PostPendingStatusCheck component JSDocs * Auto-generate editor docs for PostPendingStatusCheck updates
Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jasmussen <[email protected]>
patil-vipul
requested review from
desrosj,
ellatrix,
fluiddot,
dcalhoun,
gziolo,
adamsilverstein,
talldan,
swissspidy,
peterwilsoncc,
ntwb,
nerrad,
ryanwelcher,
ndiego,
luisherranz,
DAreRodz,
draganescu,
adamziel,
getdave,
alexstine,
atimmer,
artemiomorales,
michalczaplinski,
geriux,
mmtr,
juanmaguitar and
fabiankaegy
as code owners
|
Hey @mirka , I lost track of whether this improvement was ever applied in a different PR. In case it hasn't, do you think it's good for us to pick the task up and apply it? |
|
@ciampo There are some folks in #61163 volunteering to pick this up, FWIW. @patil-vipul Are you still willing to re-submit your PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #61163
Why?
When the is12Hour={true} setting is enabled, the AM/PM toggle relies solely on visual cues to convey its state, which presents a challenge for screen readers. This design overlooks accessibility needs, potentially creating barriers for users who rely on such assistive technologies.
How?
The previous ButtonGroup for toggling between AM/PM is replaced with ToggleGroupControl for better accessibility.
Testing Instructions
Testing Instructions for Keyboard
Tabkey.Spacebar.Screenshots or screencast