DateTimePicker: AM/PM switcher is not screen reader accessible

[mirka]

What problem does this address?

The AM/PM toggle that appears when is12Hour={ true } only expresses state through visual styling, and cannot be distinguished by screen readers.

What is your proposed solution?

A similarly styled component, RadioGroup, is already deprecated in favor of ToggleGroupControl. Since we don't really use this UI pattern anymore, can we just replace it with a ToggleGroupControl? @WordPress/gutenberg-design

[jasmussen]

ToggleGroupControl seems perfect for this case. Would the compact size prop work there? Not a blocker, but can likely be useful in this context.

[jameskoster]

Probably a dumb question and/or rabbit hole, but does this need to be a separate control? Curious whether the time input could use a combobox pattern. This would allow you to select am/pm at the same time you choose the hour, and enable selection-by-mouse.

[mirka]

does this need to be a separate control?

Good point, I see how this can be enhanced to use a ComboboxControl. We can do a quick accessibility fix now by using a ToggleGroupControl for the AM/PM toggle, and once we have a rewritten ComboboxControlV2 it might be worth enhancing the inputs.

[patil-vipul]

Raised a PR for this issue here #61562
@mirka @jasmussen

[MadGanGithub]

Hey @mirka, If this issue is open, I would like to work on this

[mirka]

@MadGanGithub It seems like @patil-vipul abandoned the PR (?), so please feel free to submit a new PR.

[patil-vipul]

@mirka I'll be pushing new PR with same changes, as the previous PR got messed up.

[ciampo]

The previous attempt #61562 was closed without merging — @MadGanGithub would you be up for working on it?

[mirka]

We need to land this in the next month or two for this to be included in WP 6.7. Do we still have any takers to work on this?

[ciampo]

Since it's been a while and no one unfortunately volunteered, here is a PR closing this issue #64800