Zoom out: add patterns loading state #61513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
May 9, 2024
| select( coreStore ) | ||
| ); | ||
| const patterns = getBlockPatternsForPostType( postType ); | ||
| return isResolving( 'getBlockPatterns' ) ? undefined : patterns; |
There was a problem hiding this comment.
@jsnajdr This is a workaround to get the resolving state across stores. Not great, but it's a private setting for now. If it returns undefined, it means the data is still loading.
There was a problem hiding this comment.
Also even within the same store isResolving on getBlockPatternsForPostType doesn't work because it's not a resolver itself.
Anyway, curious if you have thoughts.
|
Size Change: -85 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
approved these changes
May 10, 2024
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently we don't have a loading state in the patterns inserter, it just shows "no results" while loading, because the selector returns an empty array.
Why?
It's misleading to say there are no results when in fact they just haven't loaded yet.
How?
Uses the
selectBlockPatternsKeyto determine the fetch status of patterns.Testing Instructions
Screenshots or screencast