Inserter: fix loading indicator for reusable blocks #64839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ellatrix
added
the
Backport to WP Minor Release
jsnajdr
reviewed
Sep 5, 2024
| { per_page: -1 }, | ||
| ] ) | ||
| ? reusableBlocks | ||
| : undefined; |
There was a problem hiding this comment.
I don't understand this hasFinishedResolution technique. If there are valid reusableBlocks in state, but resolution hasn't finished, then the resolution must have been invalidated. And the state contains stale data that we don't want. So we add this condition to avoid getting the stale data. Is that right?
There was a problem hiding this comment.
I'm not sure I'm following. Could you elaborate? Sorry
There was a problem hiding this comment.
I'm more or less asking why we call hasFinishedResolution instead of just always returning reusableBlocks from the selector.
jsnajdr
approved these changes
Sep 10, 2024
2 tasks
cbravobernal
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #64274.
Loading state was introduced in #61513, but was not properly added to the reusable blocks selector.
Why?
If there's only reusable blocks to be fetched, it causes the loading indicator to not appear, instead it will show "no results".
How?
Use the same technique as in #61513 for the reusable blocks selector.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast