Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI with Active Support 7.0 and add Ruby 3.4 #126

Merged
merged 3 commits into from
Jan 22, 2025
+12 −3
Merged

Fix CI with Active Support 7.0 and add Ruby 3.4 #126

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
905bc19
Fix Active Support 7.0
etiennebarrie Jan 22, 2025
074b73b
Fix Active Support 7.0 with Ruby 3.4
etiennebarrie Jan 22, 2025
508c432
Ruby 3.4
etiennebarrie Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix Active Support 7.0
@etiennebarrie
etiennebarrie committed Jan 22, 2025
commit 905bc19e90eca9cbce00adead75ad7ef3b642ecf
3 changes: 3 additions & 0 deletions spec/spec_helper.rb
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# frozen_string_literal: true

# Necessary for activesupport (~> 7.0.0) + concurrent-ruby (1.3.5)
require "logger"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be in deprecation_toolkit.rb then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make deprecation_toolkit fix people's apps, which would be out-of-place. As long as your app boots, you can use the currently released version of the gem. So we don't need to change anything to the gem really here.
Here's a reproduction repo: https://github.com/etiennebarrie/rails-app/commits/7.0-deprecation_toolkit

With 7-0-stable, the application boots, the gem as released works fine.


$LOAD_PATH.unshift(File.expand_path("../lib", __dir__))
require "deprecation_toolkit"
require "deprecation_toolkit/rspec_plugin"
3 changes: 3 additions & 0 deletions test/test_helper.rb
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# frozen_string_literal: true

# Necessary for activesupport (~> 7.0.0) + concurrent-ruby (1.3.5)
require "logger"

$LOAD_PATH.unshift(File.expand_path("../lib", __dir__))
require "deprecation_toolkit"