Fix CI with Active Support 7.0 and add Ruby 3.4 #126
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcphillips
approved these changes
Jan 22, 2025
| @@ -1,5 +1,8 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # Necessary for activesupport (~> 7.0.0) + concurrent-ruby (1.3.5) | |||
| require "logger" | |||
There was a problem hiding this comment.
Should it be in deprecation_toolkit.rb then?
There was a problem hiding this comment.
That would make deprecation_toolkit fix people's apps, which would be out-of-place. As long as your app boots, you can use the currently released version of the gem. So we don't need to change anything to the gem really here.
Here's a reproduction repo: https://github.com/etiennebarrie/rails-app/commits/7.0-deprecation_toolkit
With 7-0-stable, the application boots, the gem as released works fine.
adrianna-chang-shopify
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.