Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gruvbox-material-icons-gtk: init at unstable-2021-07-25 #188402

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

gruvbox-material-icons-gtk: init at unstable-2021-07-25 #188402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f28b1f
maintainers: add xerbalind
xerbalind Aug 26, 2022
acbdc50
gruvbox-material-icons-gtk: init at unstable-2021-07-25
xerbalind Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions maintainers/maintainer-list.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14242,6 +14242,13 @@
githubId = 36407913;
name = "Uli Baum";
};
xerbalind = {
name = "Xander Bil";
email = "[email protected]";
matrix = "@xander:matrix.icth.xyz";
github = "xerbalind";
githubId = 47951455;
};
xfnw = {
email = "[email protected]";
github = "xfnw";
Expand Down
44 changes: 44 additions & 0 deletions pkgs/data/icons/gruvbox-material-icons-gtk/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
{ lib
, stdenv
, fetchFromGitHub
, gtk3
, gtk-engine-murrine
, hicolor-icon-theme
, breeze-icons
}:

stdenv.mkDerivation rec {
pname = "gruvbox-material-gtk";
version = "unstable-2021-07-25";

src = fetchFromGitHub {
owner = "TheGreatMcPain";
repo = pname;
rev = "cc255d43322ad646bb35924accb0778d5e959626";
sha256 = "sha256-1O34p9iZelqRFBloOSZkxV0Z/7Jffciptpj3fwXPHbc=";
};

nativeBuildInputs = [ gtk3 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you meant this.

Suggested change
nativeBuildInputs = [ gtk3 ];
buildInputs = [ gtk3 ];

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better as gtk3 is only being used at build-time: gtk-update-icon-cache

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Alright.


propagatedBuildInputs = [ breeze-icons hicolor-icon-theme ];

propagatedUserEnvPkgs = [ gtk-engine-murrine ];

installPhase = ''
runHook preInstall

mkdir -p $out/share/icons
cp -r icons/Gruvbox-Material-Dark $out/share/icons
gtk-update-icon-cache $out/share/icons/Gruvbox-Material-Dark

runHook postInstall
'';

meta = with lib; {
description = "Gruvbox material icons for GTK based desktop environments";
homepage = "https://github.com/TheGreatMcPain/gruvbox-material-gtk";
license = licenses.mit;
maintainers = [ maintainers.xerbalind ];
};
}

4 changes: 4 additions & 0 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25281,6 +25281,10 @@ with pkgs;
inherit (plasma5Packages) breeze-icons;
};

gruvbox-material-icons-gtk = callPackage ../data/icons/gruvbox-material-icons-gtk {
inherit (plasma5Packages) breeze-icons;
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think plasma5Packages shouldn't be used here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed, as breeze-icons sits in the scope of libsForQt5 and I noticed others are using plasma5Packages for breeze-icons too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I was just thinking that it being an icon set, it should be DE-agnostic.

gubbi-font = callPackage ../data/fonts/gubbi { };

gyre-fonts = callPackage ../data/fonts/gyre {};
Expand Down
Loading