gruvbox-material-icons-gtk: init at unstable-2021-07-25 #188402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
azahi
requested changes
Aug 27, 2022
| sha256="sha256-1O34p9iZelqRFBloOSZkxV0Z/7Jffciptpj3fwXPHbc="; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ gtk3 ]; |
There was a problem hiding this comment.
I'm guessing you meant this.
Suggested change
| nativeBuildInputs = [ gtk3 ]; | |
| buildInputs = [ gtk3 ]; |
There was a problem hiding this comment.
This is better as gtk3 is only being used at build-time: gtk-update-icon-cache
| description = "Gruvbox material icons for GTK based desktop environments"; | ||
| homepage = "https://github.com/TheGreatMcPain/gruvbox-material-gtk"; | ||
| license = licenses.mit; | ||
| platforms = platforms.unix; |
There was a problem hiding this comment.
This is the default.
Suggested change
| platforms = platforms.unix; | |
| platforms = platforms.unix; |
There was a problem hiding this comment.
My intention was to suggest you to remove this line because it's not needed. :^)
| @@ -25283,6 +25283,10 @@ with pkgs; | |||
| inherit (plasma5Packages) breeze-icons; | |||
| }; | |||
|
|
|||
| gruvbox-material-icons-gtk = callPackage ../data/icons/gruvbox-material-icons-gtk { | |||
| inherit (plasma5Packages) breeze-icons; | |||
There was a problem hiding this comment.
I think plasma5Packages shouldn't be used here.
There was a problem hiding this comment.
I assumed, as breeze-icons sits in the scope of libsForQt5 and I noticed others are using plasma5Packages for breeze-icons too.
There was a problem hiding this comment.
Fair enough. I was just thinking that it being an icon set, it should be DE-agnostic.
xerbalind
changed the title
azahi
requested changes
Aug 27, 2022
| description = "Gruvbox material icons for GTK based desktop environments"; | ||
| homepage = "https://github.com/TheGreatMcPain/gruvbox-material-gtk"; | ||
| license = licenses.mit; | ||
| platforms = platforms.unix; |
There was a problem hiding this comment.
My intention was to suggest you to remove this line because it's not needed. :^)
ofborg
bot
added
10.rebuild-darwin: 0
xerbalind
force-pushed
the
master
branch
2 times, most recently
from
754b1fa to
2f28b1f
Compare
ofborg
bot
added
10.rebuild-linux: 0
azahi
requested changes
Aug 28, 2022
pkgs/top-level/all-packages.nix
Outdated
Comment on lines
16126
to
16127
| eclint = callPackage ../development/tools/eclint { }; | ||
|
|
There was a problem hiding this comment.
I'm guessing this is merge artifact?
|
Result of 1 package built:
|
azahi
approved these changes
Aug 28, 2022
azahi
added
the
12.approvals: 1
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
ghost
closed this
ghost
reopened this
github-actions
bot
added
the
8.has: maintainer-list (update)
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Gruvbox material themed icons from https://github.com/TheGreatMcPain/gruvbox-material-gtk.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes